You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Xudong Ni via Review Board <no...@reviews.apache.org> on 2018/05/22 04:01:16 UTC
Review Request 67244: Adding enforce_container_ports flag for network
ports isolation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67244/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
To reduce deployment risk, a nonenforce mode is added for network
port isolator. When this flag is set as false(default is false),
even task uses ports not in the container resources, the container
will not raise any limitation.
Add new test for this flag and update the existing tests
Diffs (updated)
-----
docs/isolators/network-ports.md ea63968481ce52c46e0a98e242da49baf6962009
src/slave/containerizer/mesos/isolators/network/ports.hpp ba71087194a3ae74c7e40dffa9c108b02ffa10ad
src/slave/containerizer/mesos/isolators/network/ports.cpp 1f84ed4fb2a30fd095e2faec1038de1fa19a15c5
src/slave/flags.hpp a839591a2b66444ad97fced0620201dde656352d
src/slave/flags.cpp a319b5ea633c41fd8a252c5e1617ac52d1480ba5
src/tests/containerizer/ports_isolator_tests.cpp c5b9f926047792e7f9d1f0937fa5355b1dd77965
Diff: https://reviews.apache.org/r/67244/diff/1/
Testing
-------
Thanks,
Xudong Ni
Re: Review Request 67244: Adding enforce_container_ports flag for
network ports isolation.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67244/#review203552
-----------------------------------------------------------
PASS: Mesos patch 67244 was successfully built and tested.
Reviews applied: `['67244']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67244
- Mesos Reviewbot Windows
On May 22, 2018, 4:02 a.m., Xudong Ni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67244/
> -----------------------------------------------------------
>
> (Updated May 22, 2018, 4:02 a.m.)
>
>
> Review request for mesos, James Peach and Jiang Yan Xu.
>
>
> Bugs: MESOS-8340
> https://issues.apache.org/jira/browse/MESOS-8340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To reduce deployment risk, a nonenforce mode is added for network
> port isolator. When this flag is set as false(default is false),
> even task uses ports not in the container resources, the container
> will not raise any limitation.
>
> Add new test for this flag and update the existing tests
>
>
> Diffs
> -----
>
> docs/isolators/network-ports.md ea63968481ce52c46e0a98e242da49baf6962009
> src/slave/containerizer/mesos/isolators/network/ports.hpp ba71087194a3ae74c7e40dffa9c108b02ffa10ad
> src/slave/containerizer/mesos/isolators/network/ports.cpp 1f84ed4fb2a30fd095e2faec1038de1fa19a15c5
> src/slave/flags.hpp a839591a2b66444ad97fced0620201dde656352d
> src/slave/flags.cpp a319b5ea633c41fd8a252c5e1617ac52d1480ba5
> src/tests/containerizer/ports_isolator_tests.cpp c5b9f926047792e7f9d1f0937fa5355b1dd77965
>
>
> Diff: https://reviews.apache.org/r/67244/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xudong Ni
>
>
Re: Review Request 67244: Adding enforce_container_ports flag for
network ports isolation.
Posted by Xudong Ni via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67244/
-----------------------------------------------------------
(Updated May 22, 2018, 4:02 a.m.)
Review request for mesos, James Peach and Jiang Yan Xu.
Bugs: MESOS-8340
https://issues.apache.org/jira/browse/MESOS-8340
Repository: mesos
Description
-------
To reduce deployment risk, a nonenforce mode is added for network
port isolator. When this flag is set as false(default is false),
even task uses ports not in the container resources, the container
will not raise any limitation.
Add new test for this flag and update the existing tests
Diffs
-----
docs/isolators/network-ports.md ea63968481ce52c46e0a98e242da49baf6962009
src/slave/containerizer/mesos/isolators/network/ports.hpp ba71087194a3ae74c7e40dffa9c108b02ffa10ad
src/slave/containerizer/mesos/isolators/network/ports.cpp 1f84ed4fb2a30fd095e2faec1038de1fa19a15c5
src/slave/flags.hpp a839591a2b66444ad97fced0620201dde656352d
src/slave/flags.cpp a319b5ea633c41fd8a252c5e1617ac52d1480ba5
src/tests/containerizer/ports_isolator_tests.cpp c5b9f926047792e7f9d1f0937fa5355b1dd77965
Diff: https://reviews.apache.org/r/67244/diff/1/
Testing
-------
Thanks,
Xudong Ni