You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Aljoscha Krettek (Jira)" <ji...@apache.org> on 2020/09/29 09:45:00 UTC

[jira] [Closed] (FLINK-19208) Refine the tuple's equals

     [ https://issues.apache.org/jira/browse/FLINK-19208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aljoscha Krettek closed FLINK-19208.
------------------------------------
    Resolution: Won't Fix

I'm closing this for now since it's a purely cosmetic change that will cause more work to review and I don't see the benefit. (This would require changing the code generator, regenerating the Tuple code, etc, which is already too much for me.)

> Refine the tuple's equals
> -------------------------
>
>                 Key: FLINK-19208
>                 URL: https://issues.apache.org/jira/browse/FLINK-19208
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Core
>            Reporter: darion yaphet
>            Priority: Minor
>              Labels: pull-request-available
>
> When we check the tuple is equal, f0 != null ? !f0.equals(tuple.f0) : tuple.f0 != null could refine to  !Objects.equals(f0, tuple.f0) which make code more readable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)