You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Pawan Verma (Jira)" <ji...@apache.org> on 2020/05/13 07:53:00 UTC

[jira] [Commented] (OFBIZ-11696) Refactor CatalogWorker.java to remove duplicate code

    [ https://issues.apache.org/jira/browse/OFBIZ-11696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106069#comment-17106069 ] 

Pawan Verma commented on OFBIZ-11696:
-------------------------------------

[^OFBIZ-11696.patch]

Attaching a patch for this improvement. Please suggest your feedback. Thanks!

> Refactor CatalogWorker.java to remove duplicate code
> ----------------------------------------------------
>
>                 Key: OFBIZ-11696
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11696
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Pawan Verma
>            Assignee: Pawan Verma
>            Priority: Minor
>         Attachments: OFBIZ-11696.patch
>
>
> We have too much duplicate code in CatalogWorker.java 
> We can refactor it via creating a generic method and use it to fetch prodCatalogCategoryId by passing prodCatalogCategoryTypeId.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)