You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/04 23:27:43 UTC
[GitHub] [pinot] jackjlli commented on a change in pull request #7515: Do not allow query to override the execution threads over the instance-level limit
jackjlli commented on a change in pull request #7515:
URL: https://github.com/apache/pinot/pull/7515#discussion_r721783208
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -198,8 +198,13 @@ private int getMaxExecutionThreads(QueryContext queryContext) {
Map<String, String> queryOptions = queryContext.getQueryOptions();
if (queryOptions != null) {
Integer maxExecutionThreads = QueryOptions.getMaxExecutionThreads(queryOptions);
Review comment:
nit: can we rename `maxExecutionThreads` to sth like `maxExecutionThreadsFromQuery`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org