You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/10/27 15:04:06 UTC
(commons-scxml) branch master updated (27b1d0e -> 75cbb53)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-scxml.git
from 27b1d0e Merge pull request #163 from apache/dependabot/github_actions/github/codeql-action-2.22.4
new bc4d803 Don't initialize an instance or static variable to its default value
new b74701f Fix doctype
new 615ea7a Fix Checkstyle configuration
new 75cbb53 Allow Checkstyle from the command line build standalone
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
checkstyle.xml | 16 +++++++---------
pom.xml | 8 ++++++++
.../org/apache/commons/scxml2/SCXMLExecutionContext.java | 2 +-
.../java/org/apache/commons/scxml2/env/URLResolver.java | 2 +-
src/test/java/org/apache/commons/scxml2/model/Hello.java | 2 +-
5 files changed, 18 insertions(+), 12 deletions(-)
(commons-scxml) 04/04: Allow Checkstyle from the command line build standalone
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-scxml.git
commit 75cbb536837510eda63614500b24430ffb0dfc5d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Oct 27 11:03:34 2023 -0400
Allow Checkstyle from the command line build standalone
---
pom.xml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/pom.xml b/pom.xml
index eb1072a..b19c3a2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -304,6 +304,14 @@
<additionalparam>-Xdoclint:none</additionalparam>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
+ <configuration>
+ <configLocation>${basedir}/checkstyle.xml</configLocation>
+ <enableRulesSummary>false</enableRulesSummary>
+ </configuration>
+ </plugin>
</plugins>
</build>
(commons-scxml) 01/04: Don't initialize an instance or static variable to its default value
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-scxml.git
commit bc4d80360b49b53ab24e48741223633232d556d2
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Oct 27 10:58:57 2023 -0400
Don't initialize an instance or static variable to its default value
---
checkstyle.xml | 1 +
src/main/java/org/apache/commons/scxml2/SCXMLExecutionContext.java | 2 +-
src/main/java/org/apache/commons/scxml2/env/URLResolver.java | 2 +-
src/test/java/org/apache/commons/scxml2/model/Hello.java | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/checkstyle.xml b/checkstyle.xml
index b9970e9..0087e4f 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -102,6 +102,7 @@
<module name="TreeWalker">
+ <module name="ExplicitInitializationCheck" />
<property name="cacheFile" value="${checkstyle.cache.file}" />
<!-- Checks for Javadoc comments. -->
diff --git a/src/main/java/org/apache/commons/scxml2/SCXMLExecutionContext.java b/src/main/java/org/apache/commons/scxml2/SCXMLExecutionContext.java
index 72917c0..0b7aefb 100644
--- a/src/main/java/org/apache/commons/scxml2/SCXMLExecutionContext.java
+++ b/src/main/java/org/apache/commons/scxml2/SCXMLExecutionContext.java
@@ -87,7 +87,7 @@ public class SCXMLExecutionContext implements SCXMLIOProcessor {
/**
* The environment specific error reporter.
*/
- private ErrorReporter errorReporter = null;
+ private ErrorReporter errorReporter;
/**
* The notification registry.
diff --git a/src/main/java/org/apache/commons/scxml2/env/URLResolver.java b/src/main/java/org/apache/commons/scxml2/env/URLResolver.java
index 71f867a..d3f6205 100644
--- a/src/main/java/org/apache/commons/scxml2/env/URLResolver.java
+++ b/src/main/java/org/apache/commons/scxml2/env/URLResolver.java
@@ -38,7 +38,7 @@ public class URLResolver implements PathResolver, Serializable {
private static final Log log = LogFactory.getLog(PathResolver.class);
/** The base URL to resolve against. */
- private URL baseURL = null;
+ private URL baseURL;
/**
* Constructor.
diff --git a/src/test/java/org/apache/commons/scxml2/model/Hello.java b/src/test/java/org/apache/commons/scxml2/model/Hello.java
index 66d8298..a51bf12 100644
--- a/src/test/java/org/apache/commons/scxml2/model/Hello.java
+++ b/src/test/java/org/apache/commons/scxml2/model/Hello.java
@@ -28,7 +28,7 @@ public class Hello extends Action {
/** This is who we say hello to. */
private String name;
/** We count callbacks to execute() as part of the test suite. */
- public static int callbacks = 0;
+ public static int callbacks;
/** Public constructor is needed for the I in SCXML IO. */
public Hello() {
(commons-scxml) 03/04: Fix Checkstyle configuration
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-scxml.git
commit 615ea7aa791d5a56ca8ac6038f08d7d4b91bbfc6
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Oct 27 11:03:17 2023 -0400
Fix Checkstyle configuration
---
checkstyle.xml | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/checkstyle.xml b/checkstyle.xml
index 3dfb035..f13238e 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -98,10 +98,13 @@
<property name="message" value="Line has trailing spaces." />
</module>
+ <module name="LineLength">
+ <property name="max" value="160" />
+ </module>
+
<module name="TreeWalker">
<module name="ExplicitInitializationCheck" />
- <property name="cacheFile" value="${checkstyle.cache.file}" />
<!-- Checks for Javadoc comments. -->
<!-- See http://checkstyle.sf.net/config_javadoc.html -->
@@ -131,9 +134,6 @@
<!-- Checks for Size Violations. -->
<!-- See http://checkstyle.sf.net/config_sizes.html -->
- <module name="LineLength">
- <property name="max" value="160" />
- </module>
<module name="MethodLength" />
<!--module name="ParameterNumber"/ -->
@@ -174,7 +174,6 @@
<module name="InnerAssignment" />
<module name="MagicNumber" />
<module name="MissingSwitchDefault" />
- <module name="RedundantThrows" />
<module name="SimplifyBooleanExpression" />
<module name="SimplifyBooleanReturn" />
(commons-scxml) 02/04: Fix doctype
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-scxml.git
commit b74701fbde6e2500eb481db3327c3f0e81a49b06
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Oct 27 11:00:39 2023 -0400
Fix doctype
---
checkstyle.xml | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/checkstyle.xml b/checkstyle.xml
index 0087e4f..3dfb035 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -15,11 +15,9 @@
* See the License for the specific language governing permissions and
* limitations under the License.
-->
-
<!DOCTYPE module PUBLIC
- "-//Puppy Crawl//DTD Check Configuration 1.1//EN"
- "http://www.puppycrawl.com/dtds/configuration_1_1.dtd">
-
+ "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
+ "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
<!--
Checkstyle configuration that checks the sun coding conventions from: