You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:51:59 UTC
[GitHub] [flink] pnowojski opened a new pull request #13022: [hotfix][docs] Update currentInputNWatermark metrics docs including N-ary operator
pnowojski opened a new pull request #13022:
URL: https://github.com/apache/flink/pull/13022
This is a simple documentation update.
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #13022: [hotfix][docs] Update currentInputNWatermark metrics docs including N-ary operator
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #13022:
URL: https://github.com/apache/flink/pull/13022#discussion_r462822339
##########
File path: docs/monitoring/metrics.md
##########
@@ -1470,19 +1470,11 @@ Certain RocksDB native metrics are available but disabled by default, you can fi
<td>Gauge</td>
</tr>
<tr>
- <th rowspan="4"><strong>Operator</strong></th>
- <td>currentInput1Watermark</td>
Review comment:
Right, I somehow missed it :man_shrugging:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13022: [hotfix][docs] Update currentInputNWatermark metrics docs including N-ary operator
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13022:
URL: https://github.com/apache/flink/pull/13022#issuecomment-665684514
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #13022: [hotfix][docs] Update currentInputNWatermark metrics docs including N-ary operator
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #13022:
URL: https://github.com/apache/flink/pull/13022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #13022: [hotfix][docs] Update currentInputNWatermark metrics docs including N-ary operator
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #13022:
URL: https://github.com/apache/flink/pull/13022#discussion_r462818709
##########
File path: docs/monitoring/metrics.md
##########
@@ -1470,19 +1470,11 @@ Certain RocksDB native metrics are available but disabled by default, you can fi
<td>Gauge</td>
</tr>
<tr>
- <th rowspan="4"><strong>Operator</strong></th>
- <td>currentInput1Watermark</td>
Review comment:
But we are not deprecating or removing it. There used to be just `currentInput1Watermark` and `currentInput2Watermark`. Since then I've added `currentInput3Watermark`, ..., `currentInputNWatermark`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #13022: [hotfix][docs] Update currentInputNWatermark metrics docs including N-ary operator
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #13022:
URL: https://github.com/apache/flink/pull/13022#discussion_r462408619
##########
File path: docs/monitoring/metrics.md
##########
@@ -1470,19 +1470,11 @@ Certain RocksDB native metrics are available but disabled by default, you can fi
<td>Gauge</td>
</tr>
<tr>
- <th rowspan="4"><strong>Operator</strong></th>
- <td>currentInput1Watermark</td>
+ <th rowspan="3"><strong>Operator</strong></th>
+ <td>currentInput<strong>N</strong>Watermark</td>
<td>
- The last watermark this operator has received in its first input (in milliseconds).
- <p><strong>Note:</strong> Only for operators with 2 inputs.</p>
- </td>
- <td>Gauge</td>
- </tr>
- <tr>
- <td>currentInput2Watermark</td>
- <td>
- The last watermark this operator has received in its second input (in milliseconds).
- <p><strong>Note:</strong> Only for operators with 2 inputs.</p>
+ The last watermark this operator has received in its <strong>N'th</strong> input (in milliseconds). For example currentInput<strong>1</strong>Watermark, currentInput<strong>2</strong>Watermark, ...
Review comment:
nit: mention that N is 1-based
##########
File path: docs/monitoring/metrics.md
##########
@@ -1470,19 +1470,11 @@ Certain RocksDB native metrics are available but disabled by default, you can fi
<td>Gauge</td>
</tr>
<tr>
- <th rowspan="4"><strong>Operator</strong></th>
- <td>currentInput1Watermark</td>
Review comment:
I see this metric is still there. Shouldn't we mark it deprecated (in docs) instead of removing, to avoid forcing users to update their monitoring scripts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13022: [hotfix][docs] Update currentInputNWatermark metrics docs including N-ary operator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13022:
URL: https://github.com/apache/flink/pull/13022#issuecomment-665695875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "84bfbfd4ea68572e3e41d1a7893d2e0fdd0d1dc6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5013",
"triggerID" : "84bfbfd4ea68572e3e41d1a7893d2e0fdd0d1dc6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 84bfbfd4ea68572e3e41d1a7893d2e0fdd0d1dc6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5013)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13022: [hotfix][docs] Update currentInputNWatermark metrics docs including N-ary operator
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13022:
URL: https://github.com/apache/flink/pull/13022#issuecomment-665695875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "84bfbfd4ea68572e3e41d1a7893d2e0fdd0d1dc6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5013",
"triggerID" : "84bfbfd4ea68572e3e41d1a7893d2e0fdd0d1dc6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 84bfbfd4ea68572e3e41d1a7893d2e0fdd0d1dc6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5013)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org