You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/13 06:43:41 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4204: Logging time
duration for generating onheap dictionary
codecov-io commented on issue #4204: Logging time duration for generating onheap dictionary
URL: https://github.com/apache/incubator-pinot/pull/4204#issuecomment-491695742
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4204?src=pr&el=h1) Report
> Merging [#4204](https://codecov.io/gh/apache/incubator-pinot/pull/4204?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1ac071f81ffd4e428254a9b4d1cd5ec8f795239d?src=pr&el=desc) will **increase** coverage by `0.18%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4204?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4204 +/- ##
============================================
+ Coverage 67.16% 67.35% +0.18%
Complexity 20 20
============================================
Files 1034 1034
Lines 51491 51511 +20
Branches 7214 7214
============================================
+ Hits 34585 34693 +108
+ Misses 14520 14435 -85
+ Partials 2386 2383 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4204?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ore/segment/index/readers/OnHeapIntDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwSW50RGljdGlvbmFyeS5qYXZh) | `61.29% <100%> (+5.73%)` | `0 <0> (ø)` | :arrow_down: |
| [.../segment/index/readers/OnHeapDoubleDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwRG91YmxlRGljdGlvbmFyeS5qYXZh) | `57.14% <100%> (+7.14%)` | `0 <0> (ø)` | :arrow_down: |
| [...re/segment/index/readers/OnHeapLongDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwTG9uZ0RpY3Rpb25hcnkuamF2YQ==) | `57.14% <100%> (+7.14%)` | `0 <0> (ø)` | :arrow_down: |
| [...e/segment/index/readers/OnHeapFloatDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwRmxvYXREaWN0aW9uYXJ5LmphdmE=) | `58.62% <100%> (+6.62%)` | `0 <0> (ø)` | :arrow_down: |
| [.../segment/index/readers/OnHeapStringDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvT25IZWFwU3RyaW5nRGljdGlvbmFyeS5qYXZh) | `64.51% <100%> (+5.25%)` | `0 <0> (ø)` | :arrow_down: |
| [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `55% <0%> (-26.67%)` | `0% <0%> (ø)` | |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `75% <0%> (-25%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `81.81% <0%> (-9.1%)` | `0% <0%> (ø)` | |
| [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `92.3% <0%> (-7.7%)` | `0% <0%> (ø)` | |
| ... and [37 more](https://codecov.io/gh/apache/incubator-pinot/pull/4204/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4204?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4204?src=pr&el=footer). Last update [1ac071f...38cd56d](https://codecov.io/gh/apache/incubator-pinot/pull/4204?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org