[GitHub] [arrow-datafusion] Dandandan opened a new issue #260: Enable redundant_field_names clippy line

[GitBox <gi...@apache.org>]

Dandandan opened a new issue #260:
URL: https://github.com/apache/arrow-datafusion/issues/260


   **Describe the bug**
   In the github rust workflow the `redundant_field_names` is explicitly allowed:
   
   ```cargo clippy --all-targets --workspace -- -D warnings -A clippy::redundant_field_names```
   
   However, this makes the CI green, but we still get warnings when developing the code locally.
   
   **To Reproduce**
   
   add redundant field name, CI is still green.
   
   **Expected behavior**
   
   CI should reflect warnings locally, i.e. if we want to "allow" the lint for false positives, they should be allowed on a granular basis, or on project level (so the warnings we get locally reflect what we see in the CI) not from the CI command.
   
   **Additional context**
   https://github.com/apache/arrow-datafusion/pull/259
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #260: Enable redundant_field_names clippy lint

[GitBox <gi...@apache.org>]

alamb closed issue #260:
URL: https://github.com/apache/arrow-datafusion/issues/260


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org