You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by "Lewis John McGibbney (JIRA)" <ji...@apache.org> on 2013/08/01 01:51:48 UTC

[jira] [Commented] (GORA-264) Make generated data beans more java doc friendly

    [ https://issues.apache.org/jira/browse/GORA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725849#comment-13725849 ] 

Lewis John McGibbney commented on GORA-264:
-------------------------------------------

Apos I think this is really neat :)
The Javadoc is very good.
There is a small issue with the following

    /**
     * Contains all field's names.
     */
  public static final String[] _ALL_FIELDS = {"vertexId","edgeValue",};
  static {
    PersistentBase.registerFields(Edge.class, _ALL_FIELDS);
  }
  private long vertexId;
  private float edgeValue;

Where the Javadoc seems to be a spave or two too far in?
Apart from this I think it is great.
                
> Make generated data beans more java doc friendly
> ------------------------------------------------
>
>                 Key: GORA-264
>                 URL: https://issues.apache.org/jira/browse/GORA-264
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-core
>            Reporter: Renato Javier MarroquĂ­n Mogrovejo
>            Assignee: Apostolos Giannakidis
>            Priority: Minor
>         Attachments: GORA-264.patch, GVertex.java, vertex.json, vertex.json
>
>
> Generating code through our Gora Compiler is in pretty good shape but our generated data beans are not so good looking as they don't have any java doc in them. As we are already generating the whole code, I think we could add some java doc to make them look better.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira