You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2026/04/09 09:31:18 UTC
[PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
mrhhsg opened a new pull request, #62285:
URL: https://github.com/apache/doris/pull/62285
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Keep queries paused after WORKLOAD_GROUP_MEMORY_EXCEEDED when retrying the same reserve would still exceed the workload group high watermark, and add a manager unit test that exercises a real reserve failure path.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- Incrementally compiled , , and
- Full was not completed because linking triggers a large incremental rebuild in this worktree
- Behavior changed: Yes (queries that still cannot satisfy the same workload group reserve stay paused instead of being resumed immediately)
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4215099352
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4221533502
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (17/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62285_f9a62ebc9f07a947252fd28fcc9799492485753b_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62285_f9a62ebc9f07a947252fd28fcc9799492485753b_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.68% (27399/37189) |
| Line Coverage | 57.31% (295804/516106) |
| Region Coverage | 54.39% (245749/451825) |
| Branch Coverage | 56.19% (106783/190053) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4222035287
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4216623395
# BE UT Coverage Report
Increment line coverage `100.00% (17/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/e1ecfaeda5dbf5f39fc44e0ba2f026d916e22655_e1ecfaeda5dbf5f39fc44e0ba2f026d916e22655/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/e1ecfaeda5dbf5f39fc44e0ba2f026d916e22655_e1ecfaeda5dbf5f39fc44e0ba2f026d916e22655/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.99% (20123/37972) |
| Line Coverage | 36.54% (189171/517651) |
| Region Coverage | 32.81% (146903/447675) |
| Branch Coverage | 33.92% (64260/189459) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4220196271
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4219644259
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4219644619
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4222678296
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #62285:
URL: https://github.com/apache/doris/pull/62285#discussion_r3056867234
##########
be/src/runtime/workload_group/workload_group_manager.cpp:
##########
@@ -714,11 +714,20 @@ bool WorkloadGroupMgr::handle_single_query_(const std::shared_ptr<ResourceContex
return true;
}
} else if (paused_reason.is<ErrorCode::WORKLOAD_GROUP_MEMORY_EXCEEDED>()) {
- if (!wg->exceed_limit()) {
+ bool exceed_low_watermark = false;
+ bool exceed_high_watermark = false;
+ wg->check_mem_used(size_to_reserve, &exceed_low_watermark, &exceed_high_watermark);
+ if (!exceed_high_watermark) {
LOG(INFO) << "Query: " << query_id
<< " paused caused by WORKLOAD_GROUP_MEMORY_EXCEEDED, now resume it.";
requestor->task_controller()->set_memory_sufficient(true);
return true;
+ } else if (memory_usage <= limit) {
+ LOG(INFO) << "Query: " << query_id
+ << " paused caused by WORKLOAD_GROUP_MEMORY_EXCEEDED, keep it paused. "
+ << "Reserve size: " << PrettyPrinter::print_bytes(size_to_reserve)
+ << ", wg info: " << wg->memory_debug_string();
+ return false;
} else {
Status error_status = Status::MemoryLimitExceeded(
"Query {} workload group memory is exceeded"
Review Comment:
In the `memory_usage > limit` branch, the error is constructed with the message \"workload group memory is exceeded\", but the branch condition indicates the query/requestor has exceeded its own limit (`memory_usage > limit`). This makes the cancellation reason misleading for users and logs. Consider updating the message (and/or error type) to reflect query memory limit exceeded (optionally including usage/limit values), reserving the workload-group message for the watermark/limit path.
```suggestion
"Query {} memory limit is exceeded"
```
##########
be/src/runtime/workload_group/workload_group_manager.cpp:
##########
@@ -714,11 +714,20 @@ bool WorkloadGroupMgr::handle_single_query_(const std::shared_ptr<ResourceContex
return true;
}
} else if (paused_reason.is<ErrorCode::WORKLOAD_GROUP_MEMORY_EXCEEDED>()) {
- if (!wg->exceed_limit()) {
+ bool exceed_low_watermark = false;
+ bool exceed_high_watermark = false;
+ wg->check_mem_used(size_to_reserve, &exceed_low_watermark, &exceed_high_watermark);
+ if (!exceed_high_watermark) {
Review Comment:
PR description currently contains duplicated template sections and placeholder references (e.g., `close #xxx`, `Related PR: #xxx`) which conflict with the earlier stated summary and make the intended linkage/closure ambiguous. Please clean up the PR description so it reflects the actual issue/PR references and the single intended problem statement.
##########
be/test/runtime/workload_group/workload_group_manager_test.cpp:
##########
@@ -118,10 +121,9 @@ class WorkloadGroupManagerTest : public testing::Test {
return query_context;
}
- void _run_checking_loop(const std::shared_ptr<WorkloadGroup>& wg) {
+ void _run_checking_loop(const std::shared_ptr<WorkloadGroup>& wg, size_t check_times = 300) {
CountDownLatch latch(1);
- size_t check_times = 300;
- while (--check_times > 0) {
+ while (check_times-- > 0) {
Review Comment:
`while (check_times-- > 0)` causes an unsigned underflow when `check_times` is 0 (the value wraps even though the loop body won’t run). Consider rewriting to avoid wraparound (e.g., `while (check_times > 0) { --check_times; ... }` or a `for` loop) to keep the intent clearer and avoid surprising state changes.
```suggestion
while (check_times > 0) {
--check_times;
```
##########
be/test/runtime/workload_group/workload_group_manager_test.cpp:
##########
@@ -219,6 +225,70 @@ TEST_F(WorkloadGroupManagerTest, wg_exceed2) {
ASSERT_EQ(query_context->is_cancelled(), false) << "query should be canceled";
}
+TEST_F(WorkloadGroupManagerTest, wg_reserve_failed_before_query_limit_and_high_watermark) {
+ WorkloadGroupInfo wg_info {.id = 1,
+ .memory_limit = 5000,
+ .memory_low_watermark = 50,
+ .memory_high_watermark = 60,
+ .slot_mem_policy = TWgSlotMemoryPolicy::NONE};
+ auto wg = _wg_manager->get_or_create_workload_group(wg_info);
+ auto query_context = _generate_on_query(wg, 4096);
+ ThreadContext thread_context;
+ thread_context.attach_task(query_context->resource_ctx());
+
+ auto st = thread_context.thread_mem_tracker_mgr->try_reserve(2048);
+ ASSERT_TRUE(st.ok()) << st.to_string();
+ ASSERT_EQ(query_context->resource_ctx()->memory_context()->current_memory_bytes(), 2048);
+ ASSERT_EQ(query_context->resource_ctx()->memory_context()->reserved_consumption(), 2048);
+ ASSERT_LT(query_context->resource_ctx()->memory_context()->current_memory_bytes(),
+ query_context->resource_ctx()->memory_context()->mem_limit());
+ ASSERT_LT(query_context->resource_ctx()->memory_context()->current_memory_bytes() + 1024,
+ query_context->resource_ctx()->memory_context()->mem_limit());
+
+ bool exceed_low_watermark = false;
+ bool exceed_high_watermark = false;
+ wg->check_mem_used(&exceed_low_watermark, &exceed_high_watermark);
+ ASSERT_FALSE(exceed_low_watermark);
+ ASSERT_FALSE(exceed_high_watermark);
+
+ st = thread_context.thread_mem_tracker_mgr->try_reserve(1024);
+ ASSERT_TRUE(st.is<ErrorCode::WORKLOAD_GROUP_MEMORY_EXCEEDED>()) << st.to_string();
+ ASSERT_FALSE(st.is<ErrorCode::QUERY_MEMORY_EXCEEDED>()) << st.to_string();
+ ASSERT_EQ(query_context->resource_ctx()->memory_context()->current_memory_bytes(), 2048);
+ ASSERT_EQ(query_context->resource_ctx()->memory_context()->reserved_consumption(), 2048);
+
+ _wg_manager->add_paused_query(query_context->resource_ctx(), 1024, st);
+ ASSERT_FALSE(query_context->get_memory_sufficient_dependency()->ready());
+ {
+ std::unique_lock<std::mutex> lock(_wg_manager->_paused_queries_lock);
+ ASSERT_EQ(_wg_manager->_paused_queries_list[wg].size(), 1)
+ << "paused queue should not be empty";
+ }
+
+ _run_checking_loop(wg, 3);
+
+ ASSERT_FALSE(query_context->get_memory_sufficient_dependency()->ready());
+ ASSERT_TRUE(
+ query_context->resource_ctx()->task_controller()->paused_reason().is<
+ ErrorCode::WORKLOAD_GROUP_MEMORY_EXCEEDED>());
+ ASSERT_FALSE(query_context->is_cancelled());
+ {
+ std::unique_lock<std::mutex> lock(_wg_manager->_paused_queries_lock);
+ ASSERT_EQ(_wg_manager->_paused_queries_list[wg].size(), 1)
+ << "paused queue should keep the query";
+ }
+
+ {
+ std::unique_lock<std::mutex> lock(_wg_manager->_paused_queries_lock);
+ _wg_manager->_paused_queries_list.erase(wg);
+ }
+ query_context->set_memory_sufficient(true);
+ thread_context.thread_mem_tracker_mgr->shrink_reserved();
+ thread_context.detach_task();
Review Comment:
This test mutates `_paused_queries_list` directly for cleanup and relies on reaching the bottom of the test to call `shrink_reserved()` / `detach_task()`. Any earlier `ASSERT_*` failure will skip this cleanup and can leak paused-query state and thread attachment into subsequent tests, causing order-dependent failures. Prefer a scope guard/RAII cleanup (or a test-only helper API on the manager) so `_paused_queries_list` cleanup and `detach_task()` always happen.
```suggestion
{
using WorkloadGroupPtr = decltype(wg);
using QueryContextPtr = decltype(query_context);
struct ScopedTestCleanup {
WorkloadGroupMgr* wg_manager;
WorkloadGroupPtr workload_group;
QueryContextPtr query_ctx;
ThreadContext& thread_ctx;
~ScopedTestCleanup() {
{
std::unique_lock<std::mutex> lock(wg_manager->_paused_queries_lock);
wg_manager->_paused_queries_list.erase(workload_group);
}
query_ctx->set_memory_sufficient(true);
thread_ctx.thread_mem_tracker_mgr->shrink_reserved();
thread_ctx.detach_task();
}
} cleanup {_wg_manager.get(), wg, query_context, thread_context};
auto st = thread_context.thread_mem_tracker_mgr->try_reserve(2048);
ASSERT_TRUE(st.ok()) << st.to_string();
ASSERT_EQ(query_context->resource_ctx()->memory_context()->current_memory_bytes(), 2048);
ASSERT_EQ(query_context->resource_ctx()->memory_context()->reserved_consumption(), 2048);
ASSERT_LT(query_context->resource_ctx()->memory_context()->current_memory_bytes(),
query_context->resource_ctx()->memory_context()->mem_limit());
ASSERT_LT(query_context->resource_ctx()->memory_context()->current_memory_bytes() + 1024,
query_context->resource_ctx()->memory_context()->mem_limit());
bool exceed_low_watermark = false;
bool exceed_high_watermark = false;
wg->check_mem_used(&exceed_low_watermark, &exceed_high_watermark);
ASSERT_FALSE(exceed_low_watermark);
ASSERT_FALSE(exceed_high_watermark);
st = thread_context.thread_mem_tracker_mgr->try_reserve(1024);
ASSERT_TRUE(st.is<ErrorCode::WORKLOAD_GROUP_MEMORY_EXCEEDED>()) << st.to_string();
ASSERT_FALSE(st.is<ErrorCode::QUERY_MEMORY_EXCEEDED>()) << st.to_string();
ASSERT_EQ(query_context->resource_ctx()->memory_context()->current_memory_bytes(), 2048);
ASSERT_EQ(query_context->resource_ctx()->memory_context()->reserved_consumption(), 2048);
_wg_manager->add_paused_query(query_context->resource_ctx(), 1024, st);
ASSERT_FALSE(query_context->get_memory_sufficient_dependency()->ready());
{
std::unique_lock<std::mutex> lock(_wg_manager->_paused_queries_lock);
ASSERT_EQ(_wg_manager->_paused_queries_list[wg].size(), 1)
<< "paused queue should not be empty";
}
_run_checking_loop(wg, 3);
ASSERT_FALSE(query_context->get_memory_sufficient_dependency()->ready());
ASSERT_TRUE(
query_context->resource_ctx()->task_controller()->paused_reason().is<
ErrorCode::WORKLOAD_GROUP_MEMORY_EXCEEDED>());
ASSERT_FALSE(query_context->is_cancelled());
{
std::unique_lock<std::mutex> lock(_wg_manager->_paused_queries_lock);
ASSERT_EQ(_wg_manager->_paused_queries_list[wg].size(), 1)
<< "paused queue should keep the query";
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4213107668
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4225136530
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (17/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62285_52975b52e3351521bd6ecba458b00d9a3e8a60d6_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62285_52975b52e3351521bd6ecba458b00d9a3e8a60d6_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.65% (27396/37199) |
| Line Coverage | 57.31% (295890/516256) |
| Region Coverage | 54.44% (246038/451952) |
| Branch Coverage | 56.18% (106809/190105) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4216717003
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (17/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62285_e1ecfaeda5dbf5f39fc44e0ba2f026d916e22655_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62285_e1ecfaeda5dbf5f39fc44e0ba2f026d916e22655_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.58% (27362/37187) |
| Line Coverage | 57.23% (295357/516069) |
| Region Coverage | 54.53% (246390/451808) |
| Branch Coverage | 56.11% (106638/190041) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4225104214
# BE UT Coverage Report
Increment line coverage `100.00% (17/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/52975b52e3351521bd6ecba458b00d9a3e8a60d6_52975b52e3351521bd6ecba458b00d9a3e8a60d6/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/52975b52e3351521bd6ecba458b00d9a3e8a60d6_52975b52e3351521bd6ecba458b00d9a3e8a60d6/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.02% (20140/37985) |
| Line Coverage | 36.57% (189358/517840) |
| Region Coverage | 32.83% (147014/447820) |
| Branch Coverage | 33.95% (64344/189523) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4228390983
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62285:
URL: https://github.com/apache/doris/pull/62285#issuecomment-4220978515
# BE UT Coverage Report
Increment line coverage `100.00% (17/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/f9a62ebc9f07a947252fd28fcc9799492485753b_f9a62ebc9f07a947252fd28fcc9799492485753b/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/f9a62ebc9f07a947252fd28fcc9799492485753b_f9a62ebc9f07a947252fd28fcc9799492485753b/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.01% (20130/37974) |
| Line Coverage | 36.56% (189251/517688) |
| Region Coverage | 32.82% (146948/447692) |
| Branch Coverage | 33.92% (64266/189471) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Keep workload group paused queries blocked when reserve still fails [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #62285:
URL: https://github.com/apache/doris/pull/62285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org