You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/29 03:56:10 UTC

[GitHub] [incubator-pinot] mayankshriv opened a new pull request #6721: WIP: Pinot SPI refactor.

mayankshriv opened a new pull request #6721:
URL: https://github.com/apache/incubator-pinot/pull/6721

In the first phase of Pinot SPI refactor, we introduced the plugin based architecture. This is
a continuation of the refactor. Details of the refactor can be found here:
https://docs.google.com/document/d/1urROfQZuTE8JJmW3IMCeB2i3FYoEyG1TCyPsxvSaNuw/edit?usp=sharing

In this second phase, we will mainly be focuing on the following:
- We will create pinot-segment-spi and pinot-query-spi modules that will host all the segment
and query related interfaces.
- We will also create pinot-segment-default and pinot-query-default which will host the default (current)
implementations of Pinot segment and query execution engine.
- These will purely be refactors and would not create any function differences. However, to clean up
dependency issues in existing code, we may make some changes (eg create a pojo), but those also
should not modify any functionality.

In this particular PR, we are making the folowing changes:
- Introduced pinot-segment-spi.
- Moved all segment related interaces from pinot-core to pinot-segment-spi.
- In order to clean dependency issues, we have also introduced pinot-query-api, but in this PR
we are only moving bare minimal files needed for the pinot-segment-spi move.

## Description
Add a description of your PR here.
A good description should include pointers to an issue or design document, etc.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.

If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text

## Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org