You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@spark.apache.org by yiskylee <yi...@gmail.com> on 2017/05/04 14:45:22 UTC
scalastyle violation on mvn install but not on mvn package
./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
package
works, but
./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
install
triggers scalastyle violation error.
Is the scalastyle check not used on package but only on install? To install,
should I turn off "failOnViolation" in the pom?
--
View this message in context: http://apache-spark-user-list.1001560.n3.nabble.com/scalastyle-violation-on-mvn-install-but-not-on-mvn-package-tp28653.html
Sent from the Apache Spark User List mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe e-mail: user-unsubscribe@spark.apache.org
Re: scalastyle violation on mvn install but not on mvn package
Posted by Xiangyu Li <yi...@gmail.com>.
I downloaded a source code distribution of spark-2.1.0 and did the install
again, and this time I did not see any warnings. I must have used some
modified code before. Thank you for the help!
On Tue, May 23, 2017 at 11:19 AM, Mark Hamstra <ma...@clearstorydata.com>
wrote:
>
>
> On Tue, May 23, 2017 at 7:48 AM, Xiangyu Li <yi...@gmail.com> wrote:
>
>> Thank you for the answer.
>>
>> So basically it is not recommended to install Spark to your local maven
>> repository? I thought if they wanted to enforce scalastyle for better open
>> source contributions, they would have fixed all the scalastyle warnings.
>>
>
> That isn't a valid conclusion. There is nothing wrong with using maven's
> "install" with Spark. There shouldn't be any scalastyle violations.
>
>
>> On a side note, my posts on Nabble never got accepted by the mailing list
>> for some reason (I am subscribed to the mail list), and your reply does not
>> show as a reply to my question on Nabble probably for the same reason.
>> Sorry for the late reply but is using email the only way to communicate on
>> the mail list? I got another reply to this question through email but the
>> two replies are not even in the same "email conversation".
>>
>
> I don't know the mechanics of why posts do or don't show up via Nabble,
> but Nabble is neither the canonical archive nor the system of record for
> Apache mailing lists.
>
>
>> On Thu, May 4, 2017 at 8:11 PM, Mark Hamstra <ma...@clearstorydata.com>
>> wrote:
>>
>>> The check goal of the scalastyle plugin runs during the "verify" phase,
>>> which is between "package" and "install"; so running just "package" will
>>> not run scalastyle:check.
>>>
>>> On Thu, May 4, 2017 at 7:45 AM, yiskylee <yi...@gmail.com> wrote:
>>>
>>>> ./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
>>>> package
>>>> works, but
>>>> ./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
>>>> install
>>>> triggers scalastyle violation error.
>>>>
>>>> Is the scalastyle check not used on package but only on install? To
>>>> install,
>>>> should I turn off "failOnViolation" in the pom?
>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> View this message in context: http://apache-spark-user-list.
>>>> 1001560.n3.nabble.com/scalastyle-violation-on-mvn-install-bu
>>>> t-not-on-mvn-package-tp28653.html
>>>> Sent from the Apache Spark User List mailing list archive at Nabble.com.
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe e-mail: user-unsubscribe@spark.apache.org
>>>>
>>>>
>>>
>>
>>
>> --
>> Sincerely
>> Xiangyu Li
>>
>> <yi...@gmail.com>
>>
>
>
--
Sincerely
Xiangyu Li
<yi...@gmail.com>
Re: scalastyle violation on mvn install but not on mvn package
Posted by Mark Hamstra <ma...@clearstorydata.com>.
On Tue, May 23, 2017 at 7:48 AM, Xiangyu Li <yi...@gmail.com> wrote:
> Thank you for the answer.
>
> So basically it is not recommended to install Spark to your local maven
> repository? I thought if they wanted to enforce scalastyle for better open
> source contributions, they would have fixed all the scalastyle warnings.
>
That isn't a valid conclusion. There is nothing wrong with using maven's
"install" with Spark. There shouldn't be any scalastyle violations.
> On a side note, my posts on Nabble never got accepted by the mailing list
> for some reason (I am subscribed to the mail list), and your reply does not
> show as a reply to my question on Nabble probably for the same reason.
> Sorry for the late reply but is using email the only way to communicate on
> the mail list? I got another reply to this question through email but the
> two replies are not even in the same "email conversation".
>
I don't know the mechanics of why posts do or don't show up via Nabble, but
Nabble is neither the canonical archive nor the system of record for Apache
mailing lists.
> On Thu, May 4, 2017 at 8:11 PM, Mark Hamstra <ma...@clearstorydata.com>
> wrote:
>
>> The check goal of the scalastyle plugin runs during the "verify" phase,
>> which is between "package" and "install"; so running just "package" will
>> not run scalastyle:check.
>>
>> On Thu, May 4, 2017 at 7:45 AM, yiskylee <yi...@gmail.com> wrote:
>>
>>> ./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
>>> package
>>> works, but
>>> ./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
>>> install
>>> triggers scalastyle violation error.
>>>
>>> Is the scalastyle check not used on package but only on install? To
>>> install,
>>> should I turn off "failOnViolation" in the pom?
>>>
>>>
>>>
>>>
>>> --
>>> View this message in context: http://apache-spark-user-list.
>>> 1001560.n3.nabble.com/scalastyle-violation-on-mvn-install-bu
>>> t-not-on-mvn-package-tp28653.html
>>> Sent from the Apache Spark User List mailing list archive at Nabble.com.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe e-mail: user-unsubscribe@spark.apache.org
>>>
>>>
>>
>
>
> --
> Sincerely
> Xiangyu Li
>
> <yi...@gmail.com>
>
Re: scalastyle violation on mvn install but not on mvn package
Posted by Xiangyu Li <yi...@gmail.com>.
Thank you for the answer.
So basically it is not recommended to install Spark to your local maven
repository? I thought if they wanted to enforce scalastyle for better open
source contributions, they would have fixed all the scalastyle warnings.
On a side note, my posts on Nabble never got accepted by the mailing list
for some reason (I am subscribed to the mail list), and your reply does not
show as a reply to my question on Nabble probably for the same reason.
Sorry for the late reply but is using email the only way to communicate on
the mail list? I got another reply to this question through email but the
two replies are not even in the same "email conversation".
On Thu, May 4, 2017 at 8:11 PM, Mark Hamstra <ma...@clearstorydata.com>
wrote:
> The check goal of the scalastyle plugin runs during the "verify" phase,
> which is between "package" and "install"; so running just "package" will
> not run scalastyle:check.
>
> On Thu, May 4, 2017 at 7:45 AM, yiskylee <yi...@gmail.com> wrote:
>
>> ./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
>> package
>> works, but
>> ./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
>> install
>> triggers scalastyle violation error.
>>
>> Is the scalastyle check not used on package but only on install? To
>> install,
>> should I turn off "failOnViolation" in the pom?
>>
>>
>>
>>
>> --
>> View this message in context: http://apache-spark-user-list.
>> 1001560.n3.nabble.com/scalastyle-violation-on-mvn-install-
>> but-not-on-mvn-package-tp28653.html
>> Sent from the Apache Spark User List mailing list archive at Nabble.com.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe e-mail: user-unsubscribe@spark.apache.org
>>
>>
>
--
Sincerely
Xiangyu Li
<yi...@gmail.com>
Re: scalastyle violation on mvn install but not on mvn package
Posted by Mark Hamstra <ma...@clearstorydata.com>.
The check goal of the scalastyle plugin runs during the "verify" phase,
which is between "package" and "install"; so running just "package" will
not run scalastyle:check.
On Thu, May 4, 2017 at 7:45 AM, yiskylee <yi...@gmail.com> wrote:
> ./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
> package
> works, but
> ./build/mvn -Pyarn -Phadoop-2.4 -Dhadoop.version=2.4.0 -DskipTests clean
> install
> triggers scalastyle violation error.
>
> Is the scalastyle check not used on package but only on install? To
> install,
> should I turn off "failOnViolation" in the pom?
>
>
>
>
> --
> View this message in context: http://apache-spark-user-list.
> 1001560.n3.nabble.com/scalastyle-violation-on-mvn-install-but-not-on-mvn-
> package-tp28653.html
> Sent from the Apache Spark User List mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe e-mail: user-unsubscribe@spark.apache.org
>
>