You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/05 12:39:25 UTC

[GitHub] [mynewt-core] kasjer opened a new pull request #2472: MTB in core dump

kasjer opened a new pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472


   - MTB registers are stored in RAM when crash happens so MTB can be used check what lead to crash
   - MTB is also stopped in __assert_function() not only in default interrupt handler
   - disassemble of non existing memory region does not stop script for continuing
   - instruction preceding exception are displayed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774018154


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774009509


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774967503


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774009509


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer commented on a change in pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
kasjer commented on a change in pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#discussion_r571844547



##########
File path: hw/scripts/micro-trace-buffer.py
##########
@@ -37,6 +37,12 @@ class MicroTraceBuffer(gdb.Command):
 
     def __init__(self):
         super(MicroTraceBuffer, self).__init__("mtb", gdb.COMMAND_STATUS, gdb.COMPLETE_NONE)
+        try:
+            mtb_state_at_crash = gdb.lookup_symbol("mtb_state_at_crash")[0]

Review comment:
       this can also detect mtb_state_at_crash variable on live system and it this case real addresses should be used




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-775023230


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-775019030


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer commented on a change in pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
kasjer commented on a change in pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#discussion_r571856160



##########
File path: hw/scripts/micro-trace-buffer.py
##########
@@ -37,6 +37,12 @@ class MicroTraceBuffer(gdb.Command):
 
     def __init__(self):
         super(MicroTraceBuffer, self).__init__("mtb", gdb.COMMAND_STATUS, gdb.COMPLETE_NONE)
+        try:
+            mtb_state_at_crash = gdb.lookup_symbol("mtb_state_at_crash")[0]

Review comment:
       fixed by checking content of mtb_state_at_crash not only variable existence




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-779865883


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] kasjer merged pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774967503


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2472: MTB in core dump

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2472:
URL: https://github.com/apache/mynewt-core/pull/2472#issuecomment-774018154


   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### No suggestions at this time!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org