[GitHub] spark pull request: [SPARK-10524][ML] Use the soft prediction to o...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/8734#issuecomment-182126572
  
    @viirya Thanks for the updates.
    
    I think the code is correct now, but I'm going to send you a PR (to update this PR) in order to improve the test.  I agree with @sethah that the current test does not really test anything.
    
    @sethah Does it look good to you, other than the test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org