You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/05/04 11:40:07 UTC

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9176: syslog: add syslog option definition

xiaoxiang781216 commented on code in PR #9176:
URL: https://github.com/apache/nuttx/pull/9176#discussion_r1184898379


##########
include/syslog.h:
##########
@@ -162,9 +169,11 @@ extern "C"
  *
  ****************************************************************************/
 
-#if 0 /* Not supported */
-void openlog(FAR const char *ident, int option, int facility);
-#endif
+/* Not supported */
+
+static inline void openlog(const char *ident, int option, int facility)

Review Comment:
   let's change to empty function instead inline to support more compiler



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org