[GitHub] [hudi] nsivabalan commented on a diff in pull request #7901: [HUDI-5665] Adding support to re-use table configs

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #7901:
URL: https://github.com/apache/hudi/pull/7901#discussion_r1114602192


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -830,6 +830,33 @@ object DataSourceOptionsHelper {
     translatedOpt.toMap
   }
 
+  /**
+   * Some config keys differ from what user sets and whats part of table Config. this method assists in fetching the
+   * right table config and populating write configs.
+   * @param tableConfig table config of interest.
+   * @param params incoming write params.
+   * @return missing params that needs to be added to incoming write params
+   */
+  def loadParamsFromTableConfig(tableConfig: HoodieTableConfig, params: Map[String, String]) : Map[String, String] = {

Review Comment:
   sure. will take a look and fix them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org