You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gary Helmling (JIRA)" <ji...@apache.org> on 2011/04/21 21:43:06 UTC
[jira] [Created] (HBASE-3812) Tidy up naming consistency and
documentation in coprocessor framework
Tidy up naming consistency and documentation in coprocessor framework
---------------------------------------------------------------------
Key: HBASE-3812
URL: https://issues.apache.org/jira/browse/HBASE-3812
Project: HBase
Issue Type: Improvement
Components: coprocessors
Reporter: Gary Helmling
Priority: Minor
Fix For: 0.92.0
We have a few naming inconsistencies in the coprocessor API and some stale javadocs that have been spotted by Lars George as he digs through it. We should clean these up before we have an official release and are forced to go through a round of deprecation to make any changes.
Current items on the list:
* rename BaseRegionObserverCoprocessor -> BaseRegionObserver
* in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
* unnecessary public modifier for methods in RegionObserver interface
As part of this, we should take a pass through the javadocs and verify they are up to date with what is currently implemented.
Please tack on other cosmetic changes or inconsistencies as you find them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-3812) Tidy up naming consistency and
documentation in coprocessor framework
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-3812.
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Committed to trunk. Thanks for the patch Mingjie.
> Tidy up naming consistency and documentation in coprocessor framework
> ---------------------------------------------------------------------
>
> Key: HBASE-3812
> URL: https://issues.apache.org/jira/browse/HBASE-3812
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: Gary Helmling
> Assignee: Mingjie Lai
> Priority: Critical
> Fix For: 0.92.0
>
>
> We have a few naming inconsistencies in the coprocessor API and some stale javadocs that have been spotted by Lars George as he digs through it. We should clean these up before we have an official release and are forced to go through a round of deprecation to make any changes.
> Current items on the list:
> * rename BaseRegionObserverCoprocessor -> BaseRegionObserver
> * in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
> * unnecessary public modifier for methods in RegionObserver interface
> As part of this, we should take a pass through the javadocs and verify they are up to date with what is currently implemented.
> Please tack on other cosmetic changes or inconsistencies as you find them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3812) Tidy up naming consistency and
documentation in coprocessor framework
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024867#comment-13024867 ]
jiraposter@reviews.apache.org commented on HBASE-3812:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/660/#review534
-----------------------------------------------------------
Ship it!
+1 on commit (Minors below to resolve on commit)
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<https://reviews.apache.org/r/660/#comment1111>
2011
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<https://reviews.apache.org/r/660/#comment1112>
I see RegionObserver but not 'Coprocessor' Is there a CP Interface?
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java
<https://reviews.apache.org/r/660/#comment1113>
you -> your
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
<https://reviews.apache.org/r/660/#comment1114>
Good
src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java
<https://reviews.apache.org/r/660/#comment1115>
2011
- Michael
On 2011-04-25 17:11:22, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/660/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-25 17:11:22)
bq.
bq.
bq. Review request for hbase and Gary Helmling.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As described at hbase-3812:
bq. * rename BaseRegionObserverCoprocessor -> BaseRegionObserver
bq. * in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
bq. * unnecessary public modifier for methods in RegionObserver interface
bq.
bq.
bq. This addresses bug hbase-3812.
bq. https://issues.apache.org/jira/browse/hbase-3812
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java 8df6aa4
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserverCoprocessor.java a8c7cb2
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java 5c5d18d
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java c1fe58d
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java e201b3f
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 0a07e03
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 20a8d7d
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALCoprocessors.java 27c38f9
bq. src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/660/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tests passed locally.
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Tidy up naming consistency and documentation in coprocessor framework
> ---------------------------------------------------------------------
>
> Key: HBASE-3812
> URL: https://issues.apache.org/jira/browse/HBASE-3812
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: Gary Helmling
> Priority: Critical
> Fix For: 0.92.0
>
>
> We have a few naming inconsistencies in the coprocessor API and some stale javadocs that have been spotted by Lars George as he digs through it. We should clean these up before we have an official release and are forced to go through a round of deprecation to make any changes.
> Current items on the list:
> * rename BaseRegionObserverCoprocessor -> BaseRegionObserver
> * in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
> * unnecessary public modifier for methods in RegionObserver interface
> As part of this, we should take a pass through the javadocs and verify they are up to date with what is currently implemented.
> Please tack on other cosmetic changes or inconsistencies as you find them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3812) Tidy up naming consistency and
documentation in coprocessor framework
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024886#comment-13024886 ]
jiraposter@reviews.apache.org commented on HBASE-3812:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/660/
-----------------------------------------------------------
(Updated 2011-04-25 17:58:04.147369)
Review request for hbase and Gary Helmling.
Changes
-------
Changes according to Stack's review.
Summary
-------
As described at hbase-3812:
* rename BaseRegionObserverCoprocessor -> BaseRegionObserver
* in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
* unnecessary public modifier for methods in RegionObserver interface
This addresses bug hbase-3812.
https://issues.apache.org/jira/browse/hbase-3812
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java 8df6aa4
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserverCoprocessor.java a8c7cb2
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java 5c5d18d
src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java c1fe58d
src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java e201b3f
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 0a07e03
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 20a8d7d
src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALCoprocessors.java 27c38f9
src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java PRE-CREATION
Diff: https://reviews.apache.org/r/660/diff
Testing
-------
Tests passed locally.
Thanks,
Mingjie
> Tidy up naming consistency and documentation in coprocessor framework
> ---------------------------------------------------------------------
>
> Key: HBASE-3812
> URL: https://issues.apache.org/jira/browse/HBASE-3812
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: Gary Helmling
> Priority: Critical
> Fix For: 0.92.0
>
>
> We have a few naming inconsistencies in the coprocessor API and some stale javadocs that have been spotted by Lars George as he digs through it. We should clean these up before we have an official release and are forced to go through a round of deprecation to make any changes.
> Current items on the list:
> * rename BaseRegionObserverCoprocessor -> BaseRegionObserver
> * in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
> * unnecessary public modifier for methods in RegionObserver interface
> As part of this, we should take a pass through the javadocs and verify they are up to date with what is currently implemented.
> Please tack on other cosmetic changes or inconsistencies as you find them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-3812) Tidy up naming consistency and
documentation in coprocessor framework
Posted by "Mingjie Lai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingjie Lai reassigned HBASE-3812:
----------------------------------
Assignee: Mingjie Lai
> Tidy up naming consistency and documentation in coprocessor framework
> ---------------------------------------------------------------------
>
> Key: HBASE-3812
> URL: https://issues.apache.org/jira/browse/HBASE-3812
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: Gary Helmling
> Assignee: Mingjie Lai
> Priority: Critical
> Fix For: 0.92.0
>
>
> We have a few naming inconsistencies in the coprocessor API and some stale javadocs that have been spotted by Lars George as he digs through it. We should clean these up before we have an official release and are forced to go through a round of deprecation to make any changes.
> Current items on the list:
> * rename BaseRegionObserverCoprocessor -> BaseRegionObserver
> * in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
> * unnecessary public modifier for methods in RegionObserver interface
> As part of this, we should take a pass through the javadocs and verify they are up to date with what is currently implemented.
> Please tack on other cosmetic changes or inconsistencies as you find them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3812) Tidy up naming consistency and
documentation in coprocessor framework
Posted by "Gary Helmling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Helmling updated HBASE-3812:
---------------------------------
Priority: Critical (was: Minor)
Bumping priority on Stack's recommendation. Relatively minor changes, but important to get them done prior to 0.92.
> Tidy up naming consistency and documentation in coprocessor framework
> ---------------------------------------------------------------------
>
> Key: HBASE-3812
> URL: https://issues.apache.org/jira/browse/HBASE-3812
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: Gary Helmling
> Priority: Critical
> Fix For: 0.92.0
>
>
> We have a few naming inconsistencies in the coprocessor API and some stale javadocs that have been spotted by Lars George as he digs through it. We should clean these up before we have an official release and are forced to go through a round of deprecation to make any changes.
> Current items on the list:
> * rename BaseRegionObserverCoprocessor -> BaseRegionObserver
> * in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
> * unnecessary public modifier for methods in RegionObserver interface
> As part of this, we should take a pass through the javadocs and verify they are up to date with what is currently implemented.
> Please tack on other cosmetic changes or inconsistencies as you find them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3812) Tidy up naming consistency and
documentation in coprocessor framework
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022945#comment-13022945 ]
stack commented on HBASE-3812:
------------------------------
+1 I'd make this critical or a blocker if only because it'll be a pain to change them after we cut 0.92.
> Tidy up naming consistency and documentation in coprocessor framework
> ---------------------------------------------------------------------
>
> Key: HBASE-3812
> URL: https://issues.apache.org/jira/browse/HBASE-3812
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: Gary Helmling
> Priority: Minor
> Fix For: 0.92.0
>
>
> We have a few naming inconsistencies in the coprocessor API and some stale javadocs that have been spotted by Lars George as he digs through it. We should clean these up before we have an official release and are forced to go through a round of deprecation to make any changes.
> Current items on the list:
> * rename BaseRegionObserverCoprocessor -> BaseRegionObserver
> * in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
> * unnecessary public modifier for methods in RegionObserver interface
> As part of this, we should take a pass through the javadocs and verify they are up to date with what is currently implemented.
> Please tack on other cosmetic changes or inconsistencies as you find them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3812) Tidy up naming consistency and
documentation in coprocessor framework
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024854#comment-13024854 ]
jiraposter@reviews.apache.org commented on HBASE-3812:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/660/
-----------------------------------------------------------
Review request for hbase and Gary Helmling.
Summary
-------
As described at hbase-3812:
* rename BaseRegionObserverCoprocessor -> BaseRegionObserver
* in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
* unnecessary public modifier for methods in RegionObserver interface
This addresses bug hbase-3812.
https://issues.apache.org/jira/browse/hbase-3812
Diffs
-----
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseMasterObserver.java 8df6aa4
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserverCoprocessor.java a8c7cb2
src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java 5c5d18d
src/test/java/org/apache/hadoop/hbase/coprocessor/SampleRegionWALObserver.java c1fe58d
src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java e201b3f
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 0a07e03
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 20a8d7d
src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALCoprocessors.java 27c38f9
src/test/java/org/apache/hadoop/hbase/coprocessor/TestWALObserver.java PRE-CREATION
Diff: https://reviews.apache.org/r/660/diff
Testing
-------
Tests passed locally.
Thanks,
Mingjie
> Tidy up naming consistency and documentation in coprocessor framework
> ---------------------------------------------------------------------
>
> Key: HBASE-3812
> URL: https://issues.apache.org/jira/browse/HBASE-3812
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: Gary Helmling
> Priority: Critical
> Fix For: 0.92.0
>
>
> We have a few naming inconsistencies in the coprocessor API and some stale javadocs that have been spotted by Lars George as he digs through it. We should clean these up before we have an official release and are forced to go through a round of deprecation to make any changes.
> Current items on the list:
> * rename BaseRegionObserverCoprocessor -> BaseRegionObserver
> * in BaseMasterObserver, rename ObserverContext parameter variable from "env" to "c" or "ctx"
> * unnecessary public modifier for methods in RegionObserver interface
> As part of this, we should take a pass through the javadocs and verify they are up to date with what is currently implemented.
> Please tack on other cosmetic changes or inconsistencies as you find them.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira