You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "luwei16 (via GitHub)" <gi...@apache.org> on 2024/07/08 08:45:45 UTC

[PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

luwei16 opened a new pull request, #37467:
URL: https://github.com/apache/doris/pull/37467

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37467:
URL: https://github.com/apache/doris/pull/37467#issuecomment-2213552703

   TeamCity be ut coverage result:
    Function Coverage: 37.88% (8114/21418) 
    Line Coverage: 29.55% (66475/224932)
    Region Coverage: 29.02% (34265/118056)
    Branch Coverage: 24.90% (17605/70694)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/2dee781c517a31d792f28a5b3e3a1b6f41fdcde2_2dee781c517a31d792f28a5b3e3a1b6f41fdcde2/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37467:
URL: https://github.com/apache/doris/pull/37467#issuecomment-2213537461

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 49815 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2dee781c517a31d792f28a5b3e3a1b6f41fdcde2, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17684	4402	4397	4397
   q2	2066	158	155	155
   q3	10330	1955	1936	1936
   q4	10109	1274	1356	1274
   q5	8720	3940	3934	3934
   q6	265	141	126	126
   q7	2057	1628	1565	1565
   q8	9288	2755	2729	2729
   q9	10804	10437	10190	10190
   q10	8660	3479	3535	3479
   q11	428	253	252	252
   q12	471	312	317	312
   q13	18335	3939	4052	3939
   q14	375	335	323	323
   q15	517	459	461	459
   q16	684	579	564	564
   q17	1136	959	967	959
   q18	7353	6999	6784	6784
   q19	1827	1628	1587	1587
   q20	515	315	304	304
   q21	4492	4154	4117	4117
   q22	549	447	430	430
   Total cold run time: 116665 ms
   Total hot run time: 49815 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4326	4337	4283	4283
   q2	331	229	219	219
   q3	4222	4181	4136	4136
   q4	2755	2738	2754	2738
   q5	7179	7098	7118	7098
   q6	241	121	122	121
   q7	3215	2836	2888	2836
   q8	4386	4491	4513	4491
   q9	16887	16851	16857	16851
   q10	4235	4257	4280	4257
   q11	755	705	681	681
   q12	1016	856	874	856
   q13	7202	3734	3786	3734
   q14	460	418	437	418
   q15	508	461	456	456
   q16	742	687	674	674
   q17	3960	3954	3907	3907
   q18	8763	8719	8769	8719
   q19	1742	1733	1699	1699
   q20	2386	2143	2085	2085
   q21	8497	8578	8481	8481
   q22	1065	978	968	968
   Total cold run time: 84873 ms
   Total hot run time: 79708 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37467:
URL: https://github.com/apache/doris/pull/37467#issuecomment-2213576320

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.43 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 2dee781c517a31d792f28a5b3e3a1b6f41fdcde2, data reload: false
   
   query1	0.02	0.02	0.02
   query2	0.08	0.02	0.02
   query3	0.25	0.05	0.04
   query4	1.80	0.07	0.07
   query5	0.53	0.52	0.52
   query6	1.24	0.61	0.61
   query7	0.01	0.01	0.02
   query8	0.03	0.02	0.02
   query9	0.53	0.48	0.48
   query10	0.52	0.52	0.53
   query11	0.12	0.08	0.09
   query12	0.12	0.08	0.08
   query13	0.63	0.62	0.60
   query14	0.79	0.76	0.79
   query15	0.79	0.76	0.76
   query16	0.37	0.37	0.36
   query17	1.02	1.04	1.04
   query18	0.21	0.26	0.26
   query19	1.86	1.83	1.86
   query20	0.01	0.00	0.00
   query21	15.45	0.56	0.56
   query22	2.07	2.39	2.12
   query23	17.40	0.94	0.82
   query24	4.42	1.36	1.33
   query25	0.42	0.09	0.05
   query26	0.57	0.18	0.15
   query27	0.05	0.04	0.04
   query28	8.02	0.76	0.72
   query29	12.62	2.39	2.23
   query30	0.59	0.53	0.54
   query31	2.84	0.38	0.38
   query32	3.37	0.50	0.49
   query33	3.11	3.08	3.16
   query34	15.25	4.79	4.81
   query35	4.86	4.84	4.82
   query36	1.06	1.00	1.02
   query37	0.06	0.04	0.05
   query38	0.05	0.02	0.02
   query39	0.02	0.02	0.02
   query40	0.16	0.13	0.14
   query41	0.07	0.01	0.01
   query42	0.02	0.01	0.01
   query43	0.02	0.01	0.02
   Total cold run time: 103.43 s
   Total hot run time: 31.43 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37467:
URL: https://github.com/apache/doris/pull/37467#issuecomment-2213583154

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 2dee781c517a31d792f28a5b3e3a1b6f41fdcde2 with default session variables
   Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37467:
URL: https://github.com/apache/doris/pull/37467#issuecomment-2213397808

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #37467:
URL: https://github.com/apache/doris/pull/37467


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "luwei16 (via GitHub)" <gi...@apache.org>.
luwei16 commented on PR #37467:
URL: https://github.com/apache/doris/pull/37467#issuecomment-2213398454

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37467:
URL: https://github.com/apache/doris/pull/37467#issuecomment-2213422718

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](schema change) fix schema change check does not calculate reader merged rows (#33825) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37467:
URL: https://github.com/apache/doris/pull/37467#issuecomment-2213564273

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 203658 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 2dee781c517a31d792f28a5b3e3a1b6f41fdcde2, data reload: false
   
   query1	933	419	376	376
   query2	6566	2902	2717	2717
   query3	6915	209	209	209
   query4	20096	18030	18025	18025
   query5	19735	6480	6562	6480
   query6	287	219	224	219
   query7	4170	298	313	298
   query8	443	407	386	386
   query9	3124	2722	2632	2632
   query10	428	299	297	297
   query11	11516	10768	10724	10724
   query12	130	77	80	77
   query13	5594	715	698	698
   query14	17909	13263	13467	13263
   query15	370	254	244	244
   query16	6462	292	266	266
   query17	1680	1475	869	869
   query18	2315	428	434	428
   query19	211	159	154	154
   query20	76	80	81	80
   query21	198	99	95	95
   query22	5092	4962	4970	4962
   query23	32410	31972	31976	31972
   query24	6853	6496	6525	6496
   query25	523	432	450	432
   query26	527	166	163	163
   query27	1887	301	294	294
   query28	6131	2336	2306	2306
   query29	2968	2666	2867	2666
   query30	246	168	173	168
   query31	903	781	765	765
   query32	66	63	63	63
   query33	406	264	260	260
   query34	902	480	480	480
   query35	1111	915	911	911
   query36	1326	1183	1209	1183
   query37	89	61	60	60
   query38	3079	2968	2953	2953
   query39	1395	1344	1308	1308
   query40	202	92	101	92
   query41	47	49	44	44
   query42	83	84	85	84
   query43	703	772	675	675
   query44	1149	721	723	721
   query45	252	240	231	231
   query46	1233	973	983	973
   query47	2013	1689	1817	1689
   query48	1030	717	728	717
   query49	627	386	371	371
   query50	865	604	598	598
   query51	4765	4632	4622	4622
   query52	92	82	94	82
   query53	443	326	324	324
   query54	2663	2477	2509	2477
   query55	98	81	82	81
   query56	227	225	218	218
   query57	1335	1056	1154	1056
   query58	227	206	211	206
   query59	4047	4179	3923	3923
   query60	234	197	192	192
   query61	97	97	93	93
   query62	864	474	504	474
   query63	493	348	356	348
   query64	2458	1555	1530	1530
   query65	3618	3575	3570	3570
   query66	827	395	370	370
   query67	16461	15262	16531	15262
   query68	9190	646	638	638
   query69	586	355	353	353
   query70	1723	1429	1545	1429
   query71	421	315	315	315
   query72	6553	3517	3508	3508
   query73	743	320	329	320
   query74	6331	5815	5845	5815
   query75	5350	3539	3610	3539
   query76	5691	1178	1203	1178
   query77	951	254	262	254
   query78	12431	12119	11552	11552
   query79	8100	670	642	642
   query80	1248	399	401	399
   query81	493	240	234	234
   query82	1584	100	99	99
   query83	174	141	136	136
   query84	262	71	72	71
   query85	886	328	323	323
   query86	339	339	311	311
   query87	3229	3048	3020	3020
   query88	4893	2323	2303	2303
   query89	378	277	299	277
   query90	1952	216	211	211
   query91	170	141	137	137
   query92	59	57	51	51
   query93	5864	557	572	557
   query94	715	210	212	210
   query95	1118	1053	1050	1050
   query96	632	334	328	328
   query97	6508	6378	6418	6378
   query98	202	175	176	175
   query99	2830	853	843	843
   Total cold run time: 313831 ms
   Total hot run time: 203658 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org