[GitHub] [airflow] mik-laj commented on a change in pull request #5400: [AIRFLOW-4757] Selectively disable missing docstrings for tests

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #5400: [AIRFLOW-4757] Selectively disable missing docstrings for tests
URL: https://github.com/apache/airflow/pull/5400#discussion_r292595471
 
 

 ##########
 File path: scripts/ci/ci_pylint.sh
 ##########
 @@ -17,14 +17,53 @@
 # limitations under the License.
 #
 
-# Script to run Pylint on all code. Should be started from root directory of Airflow:
+# Script to run Pylint on all code. Can be started from any working directory
 # ./scripts/ci/ci_pylint.sh
 
-set -ex
+set -uo pipefail
+
+# Uncomment to see the commands executed
+# set -x
+
+MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+
+pushd ${MY_DIR}/../../ || exit 1
+
+echo
+echo "Running in $(pwd)"
+echo
+
+echo
+echo "Running pylint for source code without tests"
+echo
 
 find . -name "*.py" \
 -not -path "./.eggs/*" \
 -not -path "./airflow/www/node_modules/*" \
 -not -path "./airflow/_vendor/*" \
 -not -path "./build/*" \
+-not -path "./tests/*" \
 
 Review comment:
   I use airflow-breeze to run Airflow, but I do small modification in my environment. I use a [git worktree](https://git-scm.com/docs/git-worktree] to eliminate the need to have multiple copies of the same repository in multiple workspace.  In this case, the git does not work properly. I would like to run pylint in this environment. Not relying on git is a very good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services