You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ji...@apache.org on 2012/11/18 14:21:06 UTC

svn commit: r1410885 - in /httpd/httpd/trunk/server/mpm: event/fdqueue.c eventopt/fdqueue.c

Author: jim
Date: Sun Nov 18 13:21:05 2012
New Revision: 1410885

URL: http://svn.apache.org/viewvc?rev=1410885&view=rev
Log:
Document the check in open_logs()

Modified:
    httpd/httpd/trunk/server/mpm/event/fdqueue.c
    httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c

Modified: httpd/httpd/trunk/server/mpm/event/fdqueue.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/event/fdqueue.c?rev=1410885&r1=1410884&r2=1410885&view=diff
==============================================================================
--- httpd/httpd/trunk/server/mpm/event/fdqueue.c (original)
+++ httpd/httpd/trunk/server/mpm/event/fdqueue.c Sun Nov 18 13:21:05 2012
@@ -103,6 +103,7 @@ apr_status_t ap_queue_info_set_idle(fd_q
      * TODO: The atomics expect unsigned whereas we're using signed.
      *       Need to double check that they work as expected or else
      *       rework how we determine blocked.
+     * UPDATE: Correct operation is performed during open_logs()
      */
     prev_idlers = apr_atomic_inc32((apr_uint32_t *)&(queue_info->idlers));
 

Modified: httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c?rev=1410885&r1=1410884&r2=1410885&view=diff
==============================================================================
--- httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c (original)
+++ httpd/httpd/trunk/server/mpm/eventopt/fdqueue.c Sun Nov 18 13:21:05 2012
@@ -103,6 +103,7 @@ apr_status_t ap_queue_info_set_idle(fd_q
      * TODO: The atomics expect unsigned whereas we're using signed.
      *       Need to double check that they work as expected or else
      *       rework how we determine blocked.
+     * UPDATE: Correct operation is performed during open_logs()
      */
     prev_idlers = apr_atomic_inc32((apr_uint32_t *)&(queue_info->idlers));