You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/29 10:29:00 UTC

[jira] [Commented] (FLINK-9106) Add UnfencedMainThreadExecutor to FencedRpcEndpoint

    [ https://issues.apache.org/jira/browse/FLINK-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418706#comment-16418706 ] 

ASF GitHub Bot commented on FLINK-9106:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5784

    [FLINK-9106] [rpc] Add UnfencedMainThreadExecutor to FencedRpcEndpoint

    ## What is the purpose of the change
    
    The UnfencedMainThreadExecutor executed Runnables in the main thread context without
    checking the fencing token. This is important to set a new fencing token, for example.
    
    ## Verifying this change
    
    - Added `AsyncCallsTest#testUnfencedMainThreadExecutor`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink addUnfencedMainThreadExecutor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5784.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5784
    
----
commit 71bb6d898055f9b166148544b63a895b62125085
Author: Till Rohrmann <tr...@...>
Date:   2018-03-29T09:40:19Z

    [hotfix] Add FutureUtils.supplyAsync with SupplierWithException

commit 2e7d6fcf5b648932026371956f781d6131a94a3b
Author: Till Rohrmann <tr...@...>
Date:   2018-03-29T09:43:03Z

    [FLINK-9106] [rpc] Add UnfencedMainThreadExecutor to FencedRpcEndpoint
    
    The UnfencedMainThreadExecutor executed Runnables in the main thread context without
    checking the fencing token. This is important to set a new fencing token, for example.

----


> Add UnfencedMainThreadExecutor to FencedRpcEndpoint
> ---------------------------------------------------
>
>                 Key: FLINK-9106
>                 URL: https://issues.apache.org/jira/browse/FLINK-9106
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to run unfenced operation it would be convenient to also have an {{UnfencedMainThreadExecutor}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)