You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/05/21 14:03:41 UTC

[jira] [Updated] (WICKET-4566) Resource filtering breaks the calculation of rendered resources

     [ https://issues.apache.org/jira/browse/WICKET-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-4566:
------------------------------------

    Attachment: WICKET-4566-problem.patch

Here is a modification of ResourceDecoration's HomePage that exposes the problem.

top.js is rendered in the <head> (default bucket).
HomePage.js is rendered at the bottom of the page and depends on jQuery because it uses JQueryPluginResRef.
By adding a dependency to top.js we can see that top.js is rendered both in the <head> and as part of the bucket at the bottom of the body.
The latter should not be there.
                
> Resource filtering breaks the calculation of rendered resources
> ---------------------------------------------------------------
>
>                 Key: WICKET-4566
>                 URL: https://issues.apache.org/jira/browse/WICKET-4566
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.0.0-beta2
>            Reporter: Martin Grigorov
>            Assignee: Emond Papegaaij
>         Attachments: WICKET-4566-problem.patch
>
>
> The calculation of rendered resources at org.apache.wicket.markup.head.internal.HeaderResponse#rendered field is broken when org.apache.wicket.markup.head.filter.FilteringHeaderResponse is in use.
> The problem is that org.apache.wicket.markup.head.filter.FilteringHeaderResponse#getContent(String) creates its own instance of HeaderResponse and thus has its own 'rendered' set.
> If a filtered resource depends on a resource which is rendered in the head (i.e. in the default filtered bucked named 'headerBucket') then the latter is also rendered in the custom filter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira