You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/08/21 07:58:17 UTC
Review Request 68435: ATLAS-2830: Tag Propagation,
Entity Delete : Classification update notification not sent to entities down
the lineage present after the deleted entity.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68435/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-2830
https://issues.apache.org/jira/browse/ATLAS-2830
Repository: atlas
Description
-------
1. Create a lineage like the following :
table1 -----> table2 ----> table3 -----> table4 ----> table5
2. Add tag1 to table1 ( with default false value for removePropagationsOnEntityDelete , propagate to True)
3. drop table3
4. Edit some tag attributes of tag1 associated to table1.
5. In Atlas , the tag1 attributes are updated down the lineage till table5.
6. But , CLASSIFICATION_UPDATE notification is sent to ATLAS_ENTITIES only till table3. No notification is sent for table4 and table5.
Diffs
-----
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 066b0d0f4
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7eb32148a
Diff: https://reviews.apache.org/r/68435/diff/1/
Testing
-------
Precommit in progress.
Thanks,
Sarath Subramanian
Re: Review Request 68435: ATLAS-2830: Tag Propagation,
Entity Delete : Classification update notification not sent to entities down
the lineage present after the deleted entity.
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68435/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 12:14 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
addressed Apoorv's review comments.
Bugs: ATLAS-2830
https://issues.apache.org/jira/browse/ATLAS-2830
Repository: atlas
Description
-------
1. Create a lineage like the following :
table1 -----> table2 ----> table3 -----> table4 ----> table5
2. Add tag1 to table1 ( with default false value for removePropagationsOnEntityDelete , propagate to True)
3. drop table3
4. Edit some tag attributes of tag1 associated to table1.
5. In Atlas , the tag1 attributes are updated down the lineage till table5.
6. But , CLASSIFICATION_UPDATE notification is sent to ATLAS_ENTITIES only till table3. No notification is sent for table4 and table5.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 78ed74d65
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7eb32148a
Diff: https://reviews.apache.org/r/68435/diff/4/
Changes: https://reviews.apache.org/r/68435/diff/3-4/
Testing
-------
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/601/console
Thanks,
Sarath Subramanian
Re: Review Request 68435: ATLAS-2830: Tag Propagation,
Entity Delete : Classification update notification not sent to entities down
the lineage present after the deleted entity.
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68435/#review207674
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 1672 (patched)
<https://reviews.apache.org/r/68435/#comment291160>
Handle null, isActive doesn't do that right now.
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 1685 (patched)
<https://reviews.apache.org/r/68435/#comment291161>
same here
- Apoorv Naik
On Aug. 21, 2018, 5:13 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68435/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 5:13 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2830
> https://issues.apache.org/jira/browse/ATLAS-2830
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Create a lineage like the following :
>
> table1 -----> table2 ----> table3 -----> table4 ----> table5
>
> 2. Add tag1 to table1 ( with default false value for removePropagationsOnEntityDelete , propagate to True)
> 3. drop table3
> 4. Edit some tag attributes of tag1 associated to table1.
> 5. In Atlas , the tag1 attributes are updated down the lineage till table5.
> 6. But , CLASSIFICATION_UPDATE notification is sent to ATLAS_ENTITIES only till table3. No notification is sent for table4 and table5.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 78ed74d65
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7eb32148a
>
>
> Diff: https://reviews.apache.org/r/68435/diff/3/
>
>
> Testing
> -------
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/601/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 68435: ATLAS-2830: Tag Propagation,
Entity Delete : Classification update notification not sent to entities down
the lineage present after the deleted entity.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68435/#review207675
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 21, 2018, 5:13 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68435/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 5:13 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2830
> https://issues.apache.org/jira/browse/ATLAS-2830
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Create a lineage like the following :
>
> table1 -----> table2 ----> table3 -----> table4 ----> table5
>
> 2. Add tag1 to table1 ( with default false value for removePropagationsOnEntityDelete , propagate to True)
> 3. drop table3
> 4. Edit some tag attributes of tag1 associated to table1.
> 5. In Atlas , the tag1 attributes are updated down the lineage till table5.
> 6. But , CLASSIFICATION_UPDATE notification is sent to ATLAS_ENTITIES only till table3. No notification is sent for table4 and table5.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 78ed74d65
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7eb32148a
>
>
> Diff: https://reviews.apache.org/r/68435/diff/3/
>
>
> Testing
> -------
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/601/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 68435: ATLAS-2830: Tag Propagation,
Entity Delete : Classification update notification not sent to entities down
the lineage present after the deleted entity.
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68435/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 10:13 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
addressed review comments.
Bugs: ATLAS-2830
https://issues.apache.org/jira/browse/ATLAS-2830
Repository: atlas
Description
-------
1. Create a lineage like the following :
table1 -----> table2 ----> table3 -----> table4 ----> table5
2. Add tag1 to table1 ( with default false value for removePropagationsOnEntityDelete , propagate to True)
3. drop table3
4. Edit some tag attributes of tag1 associated to table1.
5. In Atlas , the tag1 attributes are updated down the lineage till table5.
6. But , CLASSIFICATION_UPDATE notification is sent to ATLAS_ENTITIES only till table3. No notification is sent for table4 and table5.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 78ed74d65
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7eb32148a
Diff: https://reviews.apache.org/r/68435/diff/3/
Changes: https://reviews.apache.org/r/68435/diff/2-3/
Testing
-------
Precommit in progress.
Thanks,
Sarath Subramanian
Re: Review Request 68435: ATLAS-2830: Tag Propagation,
Entity Delete : Classification update notification not sent to entities down
the lineage present after the deleted entity.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68435/#review207662
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Lines 218 (patched)
<https://reviews.apache.org/r/68435/#comment291127>
It will be good to avoid helper methods, like isActive() added here, in model classes used in REST interface.
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 1533 (patched)
<https://reviews.apache.org/r/68435/#comment291152>
'notificationVertices' can end up with duplicate entries, which can result in multiple notifications for few entities. Consider using 'Set' to avoid this case.
- Madhan Neethiraj
On Aug. 21, 2018, 7:58 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68435/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 7:58 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2830
> https://issues.apache.org/jira/browse/ATLAS-2830
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1. Create a lineage like the following :
>
> table1 -----> table2 ----> table3 -----> table4 ----> table5
>
> 2. Add tag1 to table1 ( with default false value for removePropagationsOnEntityDelete , propagate to True)
> 3. drop table3
> 4. Edit some tag attributes of tag1 associated to table1.
> 5. In Atlas , the tag1 attributes are updated down the lineage till table5.
> 6. But , CLASSIFICATION_UPDATE notification is sent to ATLAS_ENTITIES only till table3. No notification is sent for table4 and table5.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 066b0d0f4
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 78ed74d65
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 7eb32148a
>
>
> Diff: https://reviews.apache.org/r/68435/diff/2/
>
>
> Testing
> -------
>
> Precommit in progress.
>
>
> Thanks,
>
> Sarath Subramanian
>
>