You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/08 19:18:48 UTC

[GitHub] sijie commented on a change in pull request #959: Docker image for testing

sijie commented on a change in pull request #959: Docker image for testing
URL: https://github.com/apache/bookkeeper/pull/959#discussion_r160225288
 
 

 ##########
 File path: bookkeeper-dist/server/pom.xml
 ##########
 @@ -78,7 +78,7 @@
         <version>${maven-assembly-plugin.version}</version>
         <configuration>
           <finalName>bookkeeper-server-${project.version}</finalName>
-          <attach>false</attach>
+          <attach>true</attach>
 
 Review comment:
   It is pretty bad to upload the whole assembly binary to artifactory since no one is going to really use it eventually.
   
   I would suggest `tests/docker-all-version-image/pom.xml` depending on `bookkeeper-server-dist`, using dependencies plugin to copy the dependencies, if that works.
     

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services