[GitHub] [incubator-pinot] mcvsubbu commented on pull request #5543: Added configurable http listeners for controller API

[GitBox <gi...@apache.org>]

mcvsubbu commented on pull request #5543:
URL: https://github.com/apache/incubator-pinot/pull/5543#issuecomment-642983139


   Controller instance ID is used in the (older) way of running helix controller as well as Pinot controller in the same host (Dual mode). Or, when running helix controller alone. It is NOT used in pinot controller. 
   
   The good thing is that Helix controller (by itself) can use any name (I need to confirm this with Helix team, or else @kishoreg  can confirm as to what happens when one helix controller registers with one name and another with a differently formatted name in a multi-controller scenario).
   
   When running in Dual mode, however, if the leadControllerResource is NOT enabled (still a supported scenario in Pinot), the servers expect the format hostname_port in CONTROLLER/LEADER node in Helix cluster, and connect to this host name and port number to complete realtime segments.
   
   @jackjlli  has been added as a reviewer for this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org