You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "tao12345666333 (via GitHub)" <gi...@apache.org> on 2023/03/31 04:28:18 UTC

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1752: docs: add ApisixPluginConfig and update examples

tao12345666333 commented on code in PR #1752:
URL: https://github.com/apache/apisix-ingress-controller/pull/1752#discussion_r1153997823


##########
docs/en/latest/concepts/apisix_route.md:
##########
@@ -184,29 +184,37 @@ If the Plugin is not enabled in APISIX by default, you can enable it by adding i
 
 :::
 
-The example below configures [cors](https://apisix.apache.org/docs/apisix/plugins/cors/) Plugin for the route:
+The example below configures [limit-count](https://apisix.apache.org/docs/apisix/plugins/limit-count) Plugin for the route:
 
 ```yaml
 apiVersion: apisix.apache.org/v2
 kind: ApisixRoute
 metadata:
-  name: httpbin-route
+ name: httpbin-route

Review Comment:
   We should use two space indent



##########
docs/en/latest/concepts/apisix_route.md:
##########
@@ -184,29 +184,37 @@ If the Plugin is not enabled in APISIX by default, you can enable it by adding i
 
 :::
 
-The example below configures [cors](https://apisix.apache.org/docs/apisix/plugins/cors/) Plugin for the route:
+The example below configures [limit-count](https://apisix.apache.org/docs/apisix/plugins/limit-count) Plugin for the route:
 
 ```yaml
 apiVersion: apisix.apache.org/v2
 kind: ApisixRoute
 metadata:
-  name: httpbin-route
+ name: httpbin-route
 spec:
-  http:
-    - name: httpbin
-      match:
-        hosts:
-        - local.httpbin.org
-        paths:
-          - /*
-      backends:
-      - serviceName: foo
-        servicePort: 80
-      plugins:
-        - name: cors
-          enable: true
+ http:

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org