[jira] [Commented] (LOG4J2-3520) sample toolchains.xml files do not provide JDK 11

["Ron Grabowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602895#comment-17602895 ] 

Ron Grabowski commented on LOG4J2-3520:
---------------------------------------

The website wasn't updated with changes from this ticket, https://logging.apache.org/log4j/2.x/build.html from 2.18.0 still references toolchains-sample-*.xml:

{quote}
Log4j 2.x uses Maven 3 as its build tool. Log4j 2.x uses the Java 9 compiler in addition to the Java version installed in the path. This is accomplished by using Maven's toolchains support. Log4j 2 provides sample toolchains XML files in the root folder. This may be used by modifying it and installing the file as toolchains.xml in the .m2 folder or by using the following when invoking Maven.

[Macintosh] -t ./toolchains-sample-mac.xml 
[Windows] -t ./toolchains-sample-win.xml 
[Linux] -t ./toolchains-sample-linux.xml 
{quote}

build.md/html was removed in 2.19.0 with LOG4J2-3573

* https://github.com/apache/logging-log4j-site/blob/asf-staging/log4j-2.18.0/build.html
* https://github.com/apache/logging-log4j-site/tree/asf-staging/log4j-2.19.0

* https://github.com/apache/logging-log4j2/blob/rel/2.18.0/src/site/markdown/build.md
* https://github.com/apache/logging-log4j2/tree/log4j-2.19.0-rc1/src/site/markdown




> sample toolchains.xml files do not provide JDK 11
> -------------------------------------------------
>
>                 Key: LOG4J2-3520
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-3520
>             Project: Log4j 2
>          Issue Type: Documentation
>          Components: Documentation
>    Affects Versions: 2.17.2
>            Reporter: Michael Ernst
>            Assignee: Volkan Yazici
>            Priority: Minor
>             Fix For: 2.18.0
>
>
> File `BUILDING.md` says to use one of these command-line arguments:
> {quote}
> [Macintosh] -t ./toolchains-sample-mac.xml
> [Windows] -t ./toolchains-sample-win.xml
> [Linux] -t ./toolchains-sample-linux.xml
> {quote}
> But those files are inconsistent with file `.github/workflows/maven-toolchains.xml`.
> I suggest that all these files be made consistent with one another.
> (It looks to me like `.github/workflows/maven-toolchains.xml` is probably the right one to copy from.)
> Alternately, a way to prevent such mismatches in the future is to delete the 3 "sample" toolchain files and change the instructions to say to set two environment variables (for example
> {quote}
> export JAVA_HOME_8_X64=$HOME/java/jdk8
> export JAVA_HOME_11_X64=$HOME/java/jdk11
> {quote}
> ) and then use
> {quote}
> --global-toolchains ".github/workflows/maven-toolchains.xml"
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)