You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/06 01:48:03 UTC
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11734: [Bug](dependent) Dependent downstream trigger error when schedule cycle not day.
caishunfeng commented on code in PR #11734:
URL: https://github.com/apache/dolphinscheduler/pull/11734#discussion_r963185253
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DependentProcessDefinition.java:
##########
@@ -60,14 +65,14 @@ public class DependentProcessDefinition {
* get dependent cycle
* @return CycleEnum
*/
- public CycleEnum getDependentCycle() {
+ public CycleEnum getDependentCycle(long processDefinitionCode) {
Review Comment:
Please update the comment.
```suggestion
public CycleEnum getDependentCycle(long upstreamProcessDefinitionCode) {
```
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java:
##########
@@ -923,7 +924,8 @@ private List<DependentProcessDefinition> getComplementDependentDefinitionList(lo
private List<DependentProcessDefinition> checkDependentProcessDefinitionValid(
List<DependentProcessDefinition> dependentProcessDefinitionList,
CycleEnum processDefinitionCycle,
- String workerGroup) {
+ String workerGroup,
+ long processDefinitionCode) {
Review Comment:
```suggestion
long upstreamProcessDefinitionCode) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org