You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/10 12:47:43 UTC

[GitHub] [spark] zero323 opened a new pull request, #36130: [SPARK-3723][FOLLOW-UP][PYTHON][MLLIB} Rename method type and dist name literals

zero323 opened a new pull request, #36130:
URL: https://github.com/apache/spark/pull/36130

   ### What changes were proposed in this pull request?
   
   This PR renames the following literal types:
   
   - `CorrelationMethod` -> `CorrMethodType`
   - `DistName`-> `KolmogorovSmirnovTestDistNameType`
   
   in  `pyspark.mllib._typing`
   
   ### Why are the changes needed?
   
   Consistency with existing codebase.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, this feature hasn't been released yet.
   
   
   ### How was this patch tested?
   
   Existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 closed pull request #36130: [SPARK-3723][FOLLOW-UP][PYTHON][MLLIB] Rename method type and dist name literals

Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #36130: [SPARK-3723][FOLLOW-UP][PYTHON][MLLIB] Rename method type and dist name literals
URL: https://github.com/apache/spark/pull/36130


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #36130: [SPARK-3723][FOLLOW-UP][PYTHON][MLLIB} Rename method type and dist name literals

Posted by GitBox <gi...@apache.org>.
zero323 commented on PR #36130:
URL: https://github.com/apache/spark/pull/36130#issuecomment-1094266422

   cc @itholic FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #36130: [SPARK-3723][FOLLOW-UP][PYTHON][MLLIB] Rename method type and dist name literals

Posted by GitBox <gi...@apache.org>.
zero323 commented on PR #36130:
URL: https://github.com/apache/spark/pull/36130#issuecomment-1094756942

   Thanks guys!
   
   Merged into master and branch-3.3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org