You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/02/07 22:35:14 UTC

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation 

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15170


Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................

IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

In a previous change, the Kudu caching code from be/src/kudu/util was
copied to be/src/util/cache. This gets that code workable for Impala
and uses it for the DataCache.

This involves the following changes:
1. Fix up includes to point to Impala's cache implementation
2. Remove NVM Cache support and code (not used by Impala)
3. Remove CacheMetrics code (not used by Impala)
4. Move the cache code to the impala namespace
5. Modify cache-bench and cache-test to use Impala's backend
   test infrastructure
6. Switch DataCache to use be/src/util/cache

These are only boilerplate changes. The cache implementation has not
meaningfully changed.

Testing:
 - Ran core tests
 - The modified version of Kudu's cache-test passes
 - The modified version of Kudu's cache-bench runs successfully

Change-Id: I917f8352c9276373dd2761af986bf3487855271c
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
M be/src/util/CMakeLists.txt
M be/src/util/cache/CMakeLists.txt
M be/src/util/cache/cache-bench.cc
M be/src/util/cache/cache-test.cc
M be/src/util/cache/cache.cc
M be/src/util/cache/cache.h
D be/src/util/cache/nvm_cache.cc
D be/src/util/cache/nvm_cache.h
12 files changed, 74 insertions(+), 948 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/15170/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 23:52:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5262/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 02:32:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5166/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Feb 2020 23:21:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................

IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

In a previous change, the Kudu caching code from be/src/kudu/util was
copied to be/src/util/cache. This gets that code workable for Impala
and uses it for the DataCache.

This involves the following changes:
1. Fix up includes to point to Impala's cache implementation
2. Remove NVM Cache support and code (not used by Impala)
3. Remove CacheMetrics code (not used by Impala)
4. Move the cache code to the impala namespace
5. Modify cache-bench and cache-test to use Impala's backend
   test infrastructure
6. Switch DataCache to use be/src/util/cache

These are only boilerplate changes. The cache implementation has not
meaningfully changed.

Testing:
 - Ran core tests
 - The modified version of Kudu's cache-test passes
 - The modified version of Kudu's cache-bench runs successfully

Change-Id: I917f8352c9276373dd2761af986bf3487855271c
---
M be/CMakeLists.txt
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
M be/src/util/CMakeLists.txt
M be/src/util/cache/CMakeLists.txt
M be/src/util/cache/cache-bench.cc
M be/src/util/cache/cache-test.cc
M be/src/util/cache/cache.cc
M be/src/util/cache/cache.h
D be/src/util/cache/nvm_cache.cc
D be/src/util/cache/nvm_cache.h
M bin/rat_exclude_files.txt
12 files changed, 71 insertions(+), 952 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/15170/7
-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5380/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 19:21:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15170/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15170/6//COMMIT_MSG@16
PS6, Line 16: 3. Remove CacheMetrics code (not used by Impala)
> I assume we have some other way of tracking these metrics? Or are they not 
We currently do not use them for the data cache, and we maintain equivalent metrics inside the data cache.

We may want metrics directly from the cache code in future, but it would be easy to reintroduce this code using Impala metrics infrastructure (and avoid bringing in the Kudu dependencies).


http://gerrit.cloudera.org:8080/#/c/15170/6/.clang-tidy
File .clang-tidy:

http://gerrit.cloudera.org:8080/#/c/15170/6/.clang-tidy@67
PS6, Line 67: -clang-diagnostic-unreachable-code-break,\
> Might be nice to briefly mention the rationale for this in the commit messa
I ended up changing the code to remove the extra break calls. This seemed consistent with what we did elsewhere, so I've removed this.


http://gerrit.cloudera.org:8080/#/c/15170/6/be/src/runtime/io/data-cache.cc
File be/src/runtime/io/data-cache.cc:

http://gerrit.cloudera.org:8080/#/c/15170/6/be/src/runtime/io/data-cache.cc@556
PS6, Line 556:   Cache::UniqueHandle handle(
> nit: this will fit on a single line now, here and I think a couple of other
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Feb 2020 01:47:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................

IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

In a previous change, the Kudu caching code from be/src/kudu/util was
copied to be/src/util/cache. This gets that code workable for Impala
and uses it for the DataCache.

This involves the following changes:
1. Fix up includes to point to Impala's cache implementation
2. Remove NVM Cache support and code (not used by Impala)
3. Remove CacheMetrics code (not used by Impala)
4. Move the cache code to the impala namespace
5. Modify cache-bench and cache-test to use Impala's backend
   test infrastructure
6. Switch DataCache to use be/src/util/cache

These are only boilerplate changes. The cache implementation has not
meaningfully changed.

Testing:
 - Ran core tests
 - The modified version of Kudu's cache-test passes
 - The modified version of Kudu's cache-bench runs successfully

Change-Id: I917f8352c9276373dd2761af986bf3487855271c
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
M be/src/util/CMakeLists.txt
M be/src/util/cache/CMakeLists.txt
M be/src/util/cache/cache-bench.cc
M be/src/util/cache/cache-test.cc
M be/src/util/cache/cache.cc
M be/src/util/cache/cache.h
D be/src/util/cache/nvm_cache.cc
D be/src/util/cache/nvm_cache.h
M bin/rat_exclude_files.txt
13 files changed, 74 insertions(+), 949 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/15170/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15170

to look at the new patch set (#5).

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................

IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

In a previous change, the Kudu caching code from be/src/kudu/util was
copied to be/src/util/cache. This gets that code workable for Impala
and uses it for the DataCache.

This involves the following changes:
1. Fix up includes to point to Impala's cache implementation
2. Remove NVM Cache support and code (not used by Impala)
3. Remove CacheMetrics code (not used by Impala)
4. Move the cache code to the impala namespace
5. Modify cache-bench and cache-test to use Impala's backend
   test infrastructure
6. Switch DataCache to use be/src/util/cache

These are only boilerplate changes. The cache implementation has not
meaningfully changed.

Testing:
 - Ran core tests
 - The modified version of Kudu's cache-test passes
 - The modified version of Kudu's cache-bench runs successfully

Change-Id: I917f8352c9276373dd2761af986bf3487855271c
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
M be/src/util/CMakeLists.txt
M be/src/util/cache/CMakeLists.txt
M be/src/util/cache/cache-bench.cc
M be/src/util/cache/cache-test.cc
M be/src/util/cache/cache.cc
M be/src/util/cache/cache.h
D be/src/util/cache/nvm_cache.cc
D be/src/util/cache/nvm_cache.h
M bin/rat_exclude_files.txt
13 files changed, 74 insertions(+), 949 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/15170/5
-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15170/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15170/6//COMMIT_MSG@16
PS6, Line 16: 3. Remove CacheMetrics code (not used by Impala)
I assume we have some other way of tracking these metrics? Or are they not important to us?


http://gerrit.cloudera.org:8080/#/c/15170/6/.clang-tidy
File .clang-tidy:

http://gerrit.cloudera.org:8080/#/c/15170/6/.clang-tidy@67
PS6, Line 67: -clang-diagnostic-unreachable-code-break,\
Might be nice to briefly mention the rationale for this in the commit message.


http://gerrit.cloudera.org:8080/#/c/15170/6/be/src/runtime/io/data-cache.cc
File be/src/runtime/io/data-cache.cc:

http://gerrit.cloudera.org:8080/#/c/15170/6/be/src/runtime/io/data-cache.cc@556
PS6, Line 556:   Cache::UniqueHandle handle(
nit: this will fit on a single line now, here and I think a couple of other places in this file



-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Feb 2020 18:55:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5176/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Feb 2020 02:16:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 7
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 17:41:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5171/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Feb 2020 00:00:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15170 )

Change subject: IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation
......................................................................

IMPALA-8690 (prep 2): Switch DataCache to Impala's cache implementation

In a previous change, the Kudu caching code from be/src/kudu/util was
copied to be/src/util/cache. This gets that code workable for Impala
and uses it for the DataCache.

This involves the following changes:
1. Fix up includes to point to Impala's cache implementation
2. Remove NVM Cache support and code (not used by Impala)
3. Remove CacheMetrics code (not used by Impala)
4. Move the cache code to the impala namespace
5. Modify cache-bench and cache-test to use Impala's backend
   test infrastructure
6. Switch DataCache to use be/src/util/cache

These are only boilerplate changes. The cache implementation has not
meaningfully changed.

Testing:
 - Ran core tests
 - The modified version of Kudu's cache-test passes
 - The modified version of Kudu's cache-bench runs successfully

Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Reviewed-on: http://gerrit.cloudera.org:8080/15170
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/CMakeLists.txt
M be/src/runtime/io/data-cache.cc
M be/src/runtime/io/data-cache.h
M be/src/util/CMakeLists.txt
M be/src/util/cache/CMakeLists.txt
M be/src/util/cache/cache-bench.cc
M be/src/util/cache/cache-test.cc
M be/src/util/cache/cache.cc
M be/src/util/cache/cache.h
D be/src/util/cache/nvm_cache.cc
D be/src/util/cache/nvm_cache.h
M bin/rat_exclude_files.txt
12 files changed, 71 insertions(+), 952 deletions(-)

Approvals:
  Thomas Tauber-Marshall: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I917f8352c9276373dd2761af986bf3487855271c
Gerrit-Change-Number: 15170
Gerrit-PatchSet: 8
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>