You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/05/29 06:51:18 UTC

[jira] [Commented] (HADOOP-12034) Wrong comment for the filefilter function in test-patch checkstyle plugin

    [ https://issues.apache.org/jira/browse/HADOOP-12034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564199#comment-14564199 ] 

Hadoop QA commented on HADOOP-12034:
------------------------------------

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec |   0m  0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is healthy. |
| {color:blue}0{color} | @author |   0m  0s | Skipping @author checks as test-patch has been patched. |
| {color:green}+1{color} | release audit |   0m 18s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck |   0m  5s | There were no new shellcheck (v0.3.3) issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace. |
| | |   0m 26s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12736045/HADOOP-12034.001.patch |
| Optional Tests | shellcheck |
| git revision | trunk / d725dd8 |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6867/console |


This message was automatically generated.

> Wrong comment for the filefilter function in test-patch checkstyle plugin
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-12034
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12034
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>            Priority: Minor
>              Labels: newbie, test-patch
>         Attachments: HADOOP-12034.001.patch
>
>
> This comment is attached to checkstyle_filefilter function, but it is a comment for shellcheck_filefilter actually.
> {code}
> # if it ends in an explicit .sh, then this is shell code.
> # if it doesn't have an extension, we assume it is shell code too
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)