You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lianetm (via GitHub)" <gi...@apache.org> on 2024/12/10 15:33:55 UTC
[PR] [WIP]: Test new consumer default [kafka]
lianetm opened a new pull request, #18121:
URL: https://github.com/apache/kafka/pull/18121
New consumer default (+ patch to not pass unsupported session timeout to new consumer in system tests)
This is a draft just to validate the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE]: Test new consumer default [kafka]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #18121:
URL: https://github.com/apache/kafka/pull/18121#discussion_r1885731283
##########
tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerTest.java:
##########
@@ -465,6 +465,8 @@ private Consumer<byte[], byte[]> createOffsetConsumer(ClusterInstance cluster) {
private Consumer<byte[], byte[]> createGroupMetaDataConsumer(ClusterInstance cluster) {
Properties props = consumerProps(cluster);
props.put(AUTO_OFFSET_RESET_CONFIG, "earliest");
+ // TODO: review when addressing issue for formatter failures in console consumer for CONSUMER
+ props.put(ConsumerConfig.GROUP_PROTOCOL_CONFIG, GroupProtocol.CLASSIC.name());
Review Comment:
We can remove these lines after https://github.com/apache/kafka/pull/18198.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE]: Test new consumer default [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm commented on PR #18121:
URL: https://github.com/apache/kafka/pull/18121#issuecomment-2682751778
Closing for now as the plan is to make it default in the future (5.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DO NOT MERGE]: Test new consumer default [kafka]
Posted by "lianetm (via GitHub)" <gi...@apache.org>.
lianetm closed pull request #18121: [DO NOT MERGE]: Test new consumer default
URL: https://github.com/apache/kafka/pull/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org