You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by Bin Ma <ma...@gmail.com> on 2019/12/06 01:09:00 UTC

[VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Hi All,

This is a call for Vote to release Apache ServiceComb Toolkit version 0.2.0


Release Candidate :
https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/

Staging Repository :
https://repository.apache.org/content/repositories/orgapacheservicecomb-1409

Release Tag :
https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0

Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e

Release Notes :
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158

Keys to verify the Release Candidate :
https://dist.apache.org/repos/dist/dev/servicecomb/KEYS

Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
at-least 72 hours, Request all PMC members to give their vote.

[ ] +1 Release this package as 0.2.0
[ ] +0 No Opinion
[ ] -1 Do not release this package because....

On the behalf of ServiceComb Team


Wishes & Regards
-------------------------------
Mabin

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by Bin Ma <ma...@gmail.com>.
OK, Thanks @Willem

This vote would be canceled.
We will start a new vote after the issues is fixed.



Wishes & Regards
-------------------------------
Mabin



Willem Jiang <wi...@gmail.com> 于2019年12月11日周三 下午7:41写道:

> -1. (binding)
> I can build the kit on mac OSX.
> I just found there are lots of jars which are listed in the License
> file in the binary release kit.
> Such as netty, vertx and zipkin.
> I don't think toolkit need to use this jar to run.
> Please double check the release kit about it.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
> On Fri, Dec 6, 2019 at 9:09 AM Bin Ma <ma...@gmail.com> wrote:
> >
> > Hi All,
> >
> > This is a call for Vote to release Apache ServiceComb Toolkit version
> 0.2.0
> >
> >
> > Release Candidate :
> >
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
> >
> > Staging Repository :
> >
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
> >
> > Release Tag :
> > https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
> >
> > Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
> >
> > Release Notes :
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
> >
> > Keys to verify the Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> >
> > Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
> > at-least 72 hours, Request all PMC members to give their vote.
> >
> > [ ] +1 Release this package as 0.2.0
> > [ ] +0 No Opinion
> > [ ] -1 Do not release this package because....
> >
> > On the behalf of ServiceComb Team
> >
> >
> > Wishes & Regards
> > -------------------------------
> > Mabin
>

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by Willem Jiang <wi...@gmail.com>.
-1. (binding)
I can build the kit on mac OSX.
I just found there are lots of jars which are listed in the License
file in the binary release kit.
Such as netty, vertx and zipkin.
I don't think toolkit need to use this jar to run.
Please double check the release kit about it.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem
On Fri, Dec 6, 2019 at 9:09 AM Bin Ma <ma...@gmail.com> wrote:
>
> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Toolkit version 0.2.0
>
>
> Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
>
> Staging Repository :
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
>
> Release Tag :
> https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
>
> Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
>
> Release Notes :
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
>
> Keys to verify the Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
>
> Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
> at-least 72 hours, Request all PMC members to give their vote.
>
> [ ] +1 Release this package as 0.2.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because....
>
> On the behalf of ServiceComb Team
>
>
> Wishes & Regards
> -------------------------------
> Mabin

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by sen sun <as...@gmail.com>.
+1

I check done:
- Git tag and commit id are OK.
- mvn clean install build OK.
- all the links above are fine
- hashes and signature are good.

Bin Ma <ma...@gmail.com> 于2019年12月6日周五 上午9:09写道:

> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Toolkit version 0.2.0
>
>
> Release Candidate :
>
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
>
> Staging Repository :
>
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
>
> Release Tag :
> https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
>
> Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
>
> Release Notes :
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
>
> Keys to verify the Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
>
> Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
> at-least 72 hours, Request all PMC members to give their vote.
>
> [ ] +1 Release this package as 0.2.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because....
>
> On the behalf of ServiceComb Team
>
>
> Wishes & Regards
> -------------------------------
> Mabin
>

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by Mohammad Asif Siddiqui <as...@apache.org>.
+1 (binding)  
  
Checks Done:   
 -  No unexpected binary 
 -  hashes and signature is good  
 -  License and Notice exist
 -  Git tag matching archive  
  
Regards  
Asif  

On 2019/12/06 01:09:00, Bin Ma <ma...@gmail.com> wrote: 
> Hi All,
> 
> This is a call for Vote to release Apache ServiceComb Toolkit version 0.2.0
> 
> 
> Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
> 
> Staging Repository :
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
> 
> Release Tag :
> https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
> 
> Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
> 
> Release Notes :
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
> 
> Keys to verify the Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> 
> Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
> at-least 72 hours, Request all PMC members to give their vote.
> 
> [ ] +1 Release this package as 0.2.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because....
> 
> On the behalf of ServiceComb Team
> 
> 
> Wishes & Regards
> -------------------------------
> Mabin
> 

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by victor chan <vi...@gmail.com>.
+1

I check done:
- Git tag and commit id OK.
- mvn clean install OK.
- hashes and signature good.

Daniel Qian <ch...@gmail.com> 于2019年12月11日周三 上午10:30写道:

> Every software has bugs, it's ok to release 0.2.0
>
> Bin Ma <ma...@gmail.com> 于2019年12月10日周二 下午9:11写道:
> >
> > The issues involve in the test code and CI, and do not affect
> > the functions of the binary and maven plugin.
> >
> > I suggest to go on to vote 0.2.0, the issues[1] can be fixed
> > in the next version.
> >
> > any thought?@PMCs
> >
> > [1] https://issues.apache.org/jira/browse/SCB-1657
> >
> > Wishes & Regards
> > -------------------------------
> > Mabin
> >
> >
> >
> > sen sun <as...@gmail.com> 于2019年12月10日周二 上午11:38写道:
> >
> > > I have created the JIRA:
> https://issues.apache.org/jira/browse/SCB-1657
> > > Whether this issue affects the current release? Can we fix it in the
> next
> > > version?
> > >
> > > Willem Jiang <wi...@gmail.com> 于2019年12月10日周二 上午10:38写道:
> > >
> > > > Please create a JIRA to check this issue.
> > > > We may consider to enable the Action in Github to running the CI with
> > > > windows.
> > > >
> > > > Willem Jiang
> > > >
> > > > Twitter: willemjiang
> > > > Weibo: 姜宁willem
> > > >
> > > > On Tue, Dec 10, 2019 at 9:46 AM sen sun <as...@gmail.com>
> wrote:
> > > > >
> > > > > Hi, @yhs0092
> > > > >
> > > > > I have checked this unit test code.  It uses File.size to get the
> size
> > > of
> > > > > the directory.
> > > > > In Windows, it always returns zero and causes the assertion to fail
> > > > > In Linux, it is ok
> > > > > This is because their file systems are different and Files.size
> only
> > > > > guarantee the correctness of the file
> > > > >
> > > > > yhs0092 <yh...@163.com> 于2019年12月10日周二 上午12:16写道:
> > > > >
> > > > > > Hello, I find that the `mvn clean install` build is not OK in my
> > > > > > development environment. I use a Windows computer to run it.
> > > > > > Here is the error log:
> > > > > > ```
> > > > > > [INFO] Running org.apache.servicecomb.toolkit.cli.CliTest
> > > > > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time
> > > elapsed:
> > > > > > 2.884 s <<< FAILURE! - in
> org.apache.servicecomb.toolkit.cli.CliTest
> > > > > > [ERROR]
> > > > > >
> > > >
> > >
> testGenerateServiceCombCodeFromSingleContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > > > > > Time elapsed: 0.834 s  <<< FAILURE!
> > > > > > java.lang.AssertionError
> > > > > >         at
> > > > > >
> > > >
> > >
> org.apache.servicecomb.toolkit.cli.CliTest.lambda$testGenerateServiceCombCodeFromSingleContract$0(CliTest.java:54)
> > > > > >         at
> > > > > >
> > > >
> > >
> org.apache.servicecomb.toolkit.cli.CliTest.testGenerateServiceCombCodeFromSingleContract(CliTest.java:36)
> > > > > >
> > > > > >
> > > > > > [ERROR]
> > > > > >
> > > >
> > >
> testGenerateCodeFromMultiContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > > > > > Time elapsed: 0.602 s  <<< FAILURE!
> > > > > > java.lang.AssertionError
> > > > > >         at
> > > > > >
> > > >
> > >
> org.apache.servicecomb.toolkit.cli.CliTest.testGenerateCodeFromMultiContract(CliTest.java:89)
> > > > > >
> > > > > >
> > > > > > [INFO]
> > > > > > [INFO] Results:
> > > > > > [INFO]
> > > > > > [ERROR] Failures:
> > > > > > [ERROR]   CliTest.testGenerateCodeFromMultiContract:89
> > > > > > [ERROR]
> > > > > >
> > > >
> > >
> CliTest.testGenerateServiceCombCodeFromSingleContract:36->lambda$testGenerateServiceCombCodeFromSingleContract$0:54
> > > > > > [INFO]
> > > > > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
> > > > > > ```
> > > > > >
> > > > > >
> > > > > > Yours sincerely
> > > > > >
> > > > > >
> > > > > > Yao Haishi
> > > > > > yhs0092@163.com
> > > > > >
> > > > > >
> > > > > > On 12/6/2019 09:09,Bin Ma<ma...@gmail.com> wrote:
> > > > > > Hi All,
> > > > > >
> > > > > > This is a call for Vote to release Apache ServiceComb Toolkit
> version
> > > > 0.2.0
> > > > > >
> > > > > >
> > > > > > Release Candidate :
> > > > > >
> > > > > >
> > > >
> > >
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
> > > > > >
> > > > > > Staging Repository :
> > > > > >
> > > > > >
> > > >
> > >
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
> > > > > >
> > > > > > Release Tag :
> > > > > > https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
> > > > > >
> > > > > > Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
> > > > > >
> > > > > > Release Notes :
> > > > > >
> > > > > >
> > > >
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
> > > > > >
> > > > > > Keys to verify the Release Candidate :
> > > > > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > > > > >
> > > > > > Voting will start now ( Friday, 6nd Dec, 2019) and will remain
> open
> > > for
> > > > > > at-least 72 hours, Request all PMC members to give their vote.
> > > > > >
> > > > > > [ ] +1 Release this package as 0.2.0
> > > > > > [ ] +0 No Opinion
> > > > > > [ ] -1 Do not release this package because....
> > > > > >
> > > > > > On the behalf of ServiceComb Team
> > > > > >
> > > > > >
> > > > > > Wishes & Regards
> > > > > > -------------------------------
> > > > > > Mabin
> > > > > >
> > > >
> > >
>
>
>
> --
> Daniel Qian
> Apache Committer(chanjarster)
> blog:https://chanjarster.github.io
> github:https://github.com/chanjarster
> segmentfault: https://segmentfault.com/u/chanjarster
>

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by Daniel Qian <ch...@gmail.com>.
Every software has bugs, it's ok to release 0.2.0

Bin Ma <ma...@gmail.com> 于2019年12月10日周二 下午9:11写道:
>
> The issues involve in the test code and CI, and do not affect
> the functions of the binary and maven plugin.
>
> I suggest to go on to vote 0.2.0, the issues[1] can be fixed
> in the next version.
>
> any thought?@PMCs
>
> [1] https://issues.apache.org/jira/browse/SCB-1657
>
> Wishes & Regards
> -------------------------------
> Mabin
>
>
>
> sen sun <as...@gmail.com> 于2019年12月10日周二 上午11:38写道:
>
> > I have created the JIRA: https://issues.apache.org/jira/browse/SCB-1657
> > Whether this issue affects the current release? Can we fix it in the next
> > version?
> >
> > Willem Jiang <wi...@gmail.com> 于2019年12月10日周二 上午10:38写道:
> >
> > > Please create a JIRA to check this issue.
> > > We may consider to enable the Action in Github to running the CI with
> > > windows.
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Tue, Dec 10, 2019 at 9:46 AM sen sun <as...@gmail.com> wrote:
> > > >
> > > > Hi, @yhs0092
> > > >
> > > > I have checked this unit test code.  It uses File.size to get the size
> > of
> > > > the directory.
> > > > In Windows, it always returns zero and causes the assertion to fail
> > > > In Linux, it is ok
> > > > This is because their file systems are different and Files.size only
> > > > guarantee the correctness of the file
> > > >
> > > > yhs0092 <yh...@163.com> 于2019年12月10日周二 上午12:16写道:
> > > >
> > > > > Hello, I find that the `mvn clean install` build is not OK in my
> > > > > development environment. I use a Windows computer to run it.
> > > > > Here is the error log:
> > > > > ```
> > > > > [INFO] Running org.apache.servicecomb.toolkit.cli.CliTest
> > > > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time
> > elapsed:
> > > > > 2.884 s <<< FAILURE! - in org.apache.servicecomb.toolkit.cli.CliTest
> > > > > [ERROR]
> > > > >
> > >
> > testGenerateServiceCombCodeFromSingleContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > > > > Time elapsed: 0.834 s  <<< FAILURE!
> > > > > java.lang.AssertionError
> > > > >         at
> > > > >
> > >
> > org.apache.servicecomb.toolkit.cli.CliTest.lambda$testGenerateServiceCombCodeFromSingleContract$0(CliTest.java:54)
> > > > >         at
> > > > >
> > >
> > org.apache.servicecomb.toolkit.cli.CliTest.testGenerateServiceCombCodeFromSingleContract(CliTest.java:36)
> > > > >
> > > > >
> > > > > [ERROR]
> > > > >
> > >
> > testGenerateCodeFromMultiContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > > > > Time elapsed: 0.602 s  <<< FAILURE!
> > > > > java.lang.AssertionError
> > > > >         at
> > > > >
> > >
> > org.apache.servicecomb.toolkit.cli.CliTest.testGenerateCodeFromMultiContract(CliTest.java:89)
> > > > >
> > > > >
> > > > > [INFO]
> > > > > [INFO] Results:
> > > > > [INFO]
> > > > > [ERROR] Failures:
> > > > > [ERROR]   CliTest.testGenerateCodeFromMultiContract:89
> > > > > [ERROR]
> > > > >
> > >
> > CliTest.testGenerateServiceCombCodeFromSingleContract:36->lambda$testGenerateServiceCombCodeFromSingleContract$0:54
> > > > > [INFO]
> > > > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
> > > > > ```
> > > > >
> > > > >
> > > > > Yours sincerely
> > > > >
> > > > >
> > > > > Yao Haishi
> > > > > yhs0092@163.com
> > > > >
> > > > >
> > > > > On 12/6/2019 09:09,Bin Ma<ma...@gmail.com> wrote:
> > > > > Hi All,
> > > > >
> > > > > This is a call for Vote to release Apache ServiceComb Toolkit version
> > > 0.2.0
> > > > >
> > > > >
> > > > > Release Candidate :
> > > > >
> > > > >
> > >
> > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
> > > > >
> > > > > Staging Repository :
> > > > >
> > > > >
> > >
> > https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
> > > > >
> > > > > Release Tag :
> > > > > https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
> > > > >
> > > > > Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
> > > > >
> > > > > Release Notes :
> > > > >
> > > > >
> > >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
> > > > >
> > > > > Keys to verify the Release Candidate :
> > > > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > > > >
> > > > > Voting will start now ( Friday, 6nd Dec, 2019) and will remain open
> > for
> > > > > at-least 72 hours, Request all PMC members to give their vote.
> > > > >
> > > > > [ ] +1 Release this package as 0.2.0
> > > > > [ ] +0 No Opinion
> > > > > [ ] -1 Do not release this package because....
> > > > >
> > > > > On the behalf of ServiceComb Team
> > > > >
> > > > >
> > > > > Wishes & Regards
> > > > > -------------------------------
> > > > > Mabin
> > > > >
> > >
> >



-- 
Daniel Qian
Apache Committer(chanjarster)
blog:https://chanjarster.github.io
github:https://github.com/chanjarster
segmentfault: https://segmentfault.com/u/chanjarster

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by Bin Ma <ma...@gmail.com>.
The issues involve in the test code and CI, and do not affect
the functions of the binary and maven plugin.

I suggest to go on to vote 0.2.0, the issues[1] can be fixed
in the next version.

any thought?@PMCs

[1] https://issues.apache.org/jira/browse/SCB-1657

Wishes & Regards
-------------------------------
Mabin



sen sun <as...@gmail.com> 于2019年12月10日周二 上午11:38写道:

> I have created the JIRA: https://issues.apache.org/jira/browse/SCB-1657
> Whether this issue affects the current release? Can we fix it in the next
> version?
>
> Willem Jiang <wi...@gmail.com> 于2019年12月10日周二 上午10:38写道:
>
> > Please create a JIRA to check this issue.
> > We may consider to enable the Action in Github to running the CI with
> > windows.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Tue, Dec 10, 2019 at 9:46 AM sen sun <as...@gmail.com> wrote:
> > >
> > > Hi, @yhs0092
> > >
> > > I have checked this unit test code.  It uses File.size to get the size
> of
> > > the directory.
> > > In Windows, it always returns zero and causes the assertion to fail
> > > In Linux, it is ok
> > > This is because their file systems are different and Files.size only
> > > guarantee the correctness of the file
> > >
> > > yhs0092 <yh...@163.com> 于2019年12月10日周二 上午12:16写道:
> > >
> > > > Hello, I find that the `mvn clean install` build is not OK in my
> > > > development environment. I use a Windows computer to run it.
> > > > Here is the error log:
> > > > ```
> > > > [INFO] Running org.apache.servicecomb.toolkit.cli.CliTest
> > > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time
> elapsed:
> > > > 2.884 s <<< FAILURE! - in org.apache.servicecomb.toolkit.cli.CliTest
> > > > [ERROR]
> > > >
> >
> testGenerateServiceCombCodeFromSingleContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > > > Time elapsed: 0.834 s  <<< FAILURE!
> > > > java.lang.AssertionError
> > > >         at
> > > >
> >
> org.apache.servicecomb.toolkit.cli.CliTest.lambda$testGenerateServiceCombCodeFromSingleContract$0(CliTest.java:54)
> > > >         at
> > > >
> >
> org.apache.servicecomb.toolkit.cli.CliTest.testGenerateServiceCombCodeFromSingleContract(CliTest.java:36)
> > > >
> > > >
> > > > [ERROR]
> > > >
> >
> testGenerateCodeFromMultiContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > > > Time elapsed: 0.602 s  <<< FAILURE!
> > > > java.lang.AssertionError
> > > >         at
> > > >
> >
> org.apache.servicecomb.toolkit.cli.CliTest.testGenerateCodeFromMultiContract(CliTest.java:89)
> > > >
> > > >
> > > > [INFO]
> > > > [INFO] Results:
> > > > [INFO]
> > > > [ERROR] Failures:
> > > > [ERROR]   CliTest.testGenerateCodeFromMultiContract:89
> > > > [ERROR]
> > > >
> >
> CliTest.testGenerateServiceCombCodeFromSingleContract:36->lambda$testGenerateServiceCombCodeFromSingleContract$0:54
> > > > [INFO]
> > > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
> > > > ```
> > > >
> > > >
> > > > Yours sincerely
> > > >
> > > >
> > > > Yao Haishi
> > > > yhs0092@163.com
> > > >
> > > >
> > > > On 12/6/2019 09:09,Bin Ma<ma...@gmail.com> wrote:
> > > > Hi All,
> > > >
> > > > This is a call for Vote to release Apache ServiceComb Toolkit version
> > 0.2.0
> > > >
> > > >
> > > > Release Candidate :
> > > >
> > > >
> >
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
> > > >
> > > > Staging Repository :
> > > >
> > > >
> >
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
> > > >
> > > > Release Tag :
> > > > https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
> > > >
> > > > Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
> > > >
> > > > Release Notes :
> > > >
> > > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
> > > >
> > > > Keys to verify the Release Candidate :
> > > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > > >
> > > > Voting will start now ( Friday, 6nd Dec, 2019) and will remain open
> for
> > > > at-least 72 hours, Request all PMC members to give their vote.
> > > >
> > > > [ ] +1 Release this package as 0.2.0
> > > > [ ] +0 No Opinion
> > > > [ ] -1 Do not release this package because....
> > > >
> > > > On the behalf of ServiceComb Team
> > > >
> > > >
> > > > Wishes & Regards
> > > > -------------------------------
> > > > Mabin
> > > >
> >
>

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by sen sun <as...@gmail.com>.
I have created the JIRA: https://issues.apache.org/jira/browse/SCB-1657
Whether this issue affects the current release? Can we fix it in the next
version?

Willem Jiang <wi...@gmail.com> 于2019年12月10日周二 上午10:38写道:

> Please create a JIRA to check this issue.
> We may consider to enable the Action in Github to running the CI with
> windows.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Tue, Dec 10, 2019 at 9:46 AM sen sun <as...@gmail.com> wrote:
> >
> > Hi, @yhs0092
> >
> > I have checked this unit test code.  It uses File.size to get the size of
> > the directory.
> > In Windows, it always returns zero and causes the assertion to fail
> > In Linux, it is ok
> > This is because their file systems are different and Files.size only
> > guarantee the correctness of the file
> >
> > yhs0092 <yh...@163.com> 于2019年12月10日周二 上午12:16写道:
> >
> > > Hello, I find that the `mvn clean install` build is not OK in my
> > > development environment. I use a Windows computer to run it.
> > > Here is the error log:
> > > ```
> > > [INFO] Running org.apache.servicecomb.toolkit.cli.CliTest
> > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
> > > 2.884 s <<< FAILURE! - in org.apache.servicecomb.toolkit.cli.CliTest
> > > [ERROR]
> > >
> testGenerateServiceCombCodeFromSingleContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > > Time elapsed: 0.834 s  <<< FAILURE!
> > > java.lang.AssertionError
> > >         at
> > >
> org.apache.servicecomb.toolkit.cli.CliTest.lambda$testGenerateServiceCombCodeFromSingleContract$0(CliTest.java:54)
> > >         at
> > >
> org.apache.servicecomb.toolkit.cli.CliTest.testGenerateServiceCombCodeFromSingleContract(CliTest.java:36)
> > >
> > >
> > > [ERROR]
> > >
> testGenerateCodeFromMultiContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > > Time elapsed: 0.602 s  <<< FAILURE!
> > > java.lang.AssertionError
> > >         at
> > >
> org.apache.servicecomb.toolkit.cli.CliTest.testGenerateCodeFromMultiContract(CliTest.java:89)
> > >
> > >
> > > [INFO]
> > > [INFO] Results:
> > > [INFO]
> > > [ERROR] Failures:
> > > [ERROR]   CliTest.testGenerateCodeFromMultiContract:89
> > > [ERROR]
> > >
> CliTest.testGenerateServiceCombCodeFromSingleContract:36->lambda$testGenerateServiceCombCodeFromSingleContract$0:54
> > > [INFO]
> > > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
> > > ```
> > >
> > >
> > > Yours sincerely
> > >
> > >
> > > Yao Haishi
> > > yhs0092@163.com
> > >
> > >
> > > On 12/6/2019 09:09,Bin Ma<ma...@gmail.com> wrote:
> > > Hi All,
> > >
> > > This is a call for Vote to release Apache ServiceComb Toolkit version
> 0.2.0
> > >
> > >
> > > Release Candidate :
> > >
> > >
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
> > >
> > > Staging Repository :
> > >
> > >
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
> > >
> > > Release Tag :
> > > https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
> > >
> > > Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
> > >
> > > Release Notes :
> > >
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
> > >
> > > Keys to verify the Release Candidate :
> > > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> > >
> > > Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
> > > at-least 72 hours, Request all PMC members to give their vote.
> > >
> > > [ ] +1 Release this package as 0.2.0
> > > [ ] +0 No Opinion
> > > [ ] -1 Do not release this package because....
> > >
> > > On the behalf of ServiceComb Team
> > >
> > >
> > > Wishes & Regards
> > > -------------------------------
> > > Mabin
> > >
>

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by Willem Jiang <wi...@gmail.com>.
Please create a JIRA to check this issue.
We may consider to enable the Action in Github to running the CI with windows.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Tue, Dec 10, 2019 at 9:46 AM sen sun <as...@gmail.com> wrote:
>
> Hi, @yhs0092
>
> I have checked this unit test code.  It uses File.size to get the size of
> the directory.
> In Windows, it always returns zero and causes the assertion to fail
> In Linux, it is ok
> This is because their file systems are different and Files.size only
> guarantee the correctness of the file
>
> yhs0092 <yh...@163.com> 于2019年12月10日周二 上午12:16写道:
>
> > Hello, I find that the `mvn clean install` build is not OK in my
> > development environment. I use a Windows computer to run it.
> > Here is the error log:
> > ```
> > [INFO] Running org.apache.servicecomb.toolkit.cli.CliTest
> > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
> > 2.884 s <<< FAILURE! - in org.apache.servicecomb.toolkit.cli.CliTest
> > [ERROR]
> > testGenerateServiceCombCodeFromSingleContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > Time elapsed: 0.834 s  <<< FAILURE!
> > java.lang.AssertionError
> >         at
> > org.apache.servicecomb.toolkit.cli.CliTest.lambda$testGenerateServiceCombCodeFromSingleContract$0(CliTest.java:54)
> >         at
> > org.apache.servicecomb.toolkit.cli.CliTest.testGenerateServiceCombCodeFromSingleContract(CliTest.java:36)
> >
> >
> > [ERROR]
> > testGenerateCodeFromMultiContract(org.apache.servicecomb.toolkit.cli.CliTest)
> > Time elapsed: 0.602 s  <<< FAILURE!
> > java.lang.AssertionError
> >         at
> > org.apache.servicecomb.toolkit.cli.CliTest.testGenerateCodeFromMultiContract(CliTest.java:89)
> >
> >
> > [INFO]
> > [INFO] Results:
> > [INFO]
> > [ERROR] Failures:
> > [ERROR]   CliTest.testGenerateCodeFromMultiContract:89
> > [ERROR]
> >  CliTest.testGenerateServiceCombCodeFromSingleContract:36->lambda$testGenerateServiceCombCodeFromSingleContract$0:54
> > [INFO]
> > [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
> > ```
> >
> >
> > Yours sincerely
> >
> >
> > Yao Haishi
> > yhs0092@163.com
> >
> >
> > On 12/6/2019 09:09,Bin Ma<ma...@gmail.com> wrote:
> > Hi All,
> >
> > This is a call for Vote to release Apache ServiceComb Toolkit version 0.2.0
> >
> >
> > Release Candidate :
> >
> > https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
> >
> > Staging Repository :
> >
> > https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
> >
> > Release Tag :
> > https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
> >
> > Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
> >
> > Release Notes :
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
> >
> > Keys to verify the Release Candidate :
> > https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
> >
> > Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
> > at-least 72 hours, Request all PMC members to give their vote.
> >
> > [ ] +1 Release this package as 0.2.0
> > [ ] +0 No Opinion
> > [ ] -1 Do not release this package because....
> >
> > On the behalf of ServiceComb Team
> >
> >
> > Wishes & Regards
> > -------------------------------
> > Mabin
> >

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by sen sun <as...@gmail.com>.
Hi, @yhs0092

I have checked this unit test code.  It uses File.size to get the size of
the directory.
In Windows, it always returns zero and causes the assertion to fail
In Linux, it is ok
This is because their file systems are different and Files.size only
guarantee the correctness of the file

yhs0092 <yh...@163.com> 于2019年12月10日周二 上午12:16写道:

> Hello, I find that the `mvn clean install` build is not OK in my
> development environment. I use a Windows computer to run it.
> Here is the error log:
> ```
> [INFO] Running org.apache.servicecomb.toolkit.cli.CliTest
> [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed:
> 2.884 s <<< FAILURE! - in org.apache.servicecomb.toolkit.cli.CliTest
> [ERROR]
> testGenerateServiceCombCodeFromSingleContract(org.apache.servicecomb.toolkit.cli.CliTest)
> Time elapsed: 0.834 s  <<< FAILURE!
> java.lang.AssertionError
>         at
> org.apache.servicecomb.toolkit.cli.CliTest.lambda$testGenerateServiceCombCodeFromSingleContract$0(CliTest.java:54)
>         at
> org.apache.servicecomb.toolkit.cli.CliTest.testGenerateServiceCombCodeFromSingleContract(CliTest.java:36)
>
>
> [ERROR]
> testGenerateCodeFromMultiContract(org.apache.servicecomb.toolkit.cli.CliTest)
> Time elapsed: 0.602 s  <<< FAILURE!
> java.lang.AssertionError
>         at
> org.apache.servicecomb.toolkit.cli.CliTest.testGenerateCodeFromMultiContract(CliTest.java:89)
>
>
> [INFO]
> [INFO] Results:
> [INFO]
> [ERROR] Failures:
> [ERROR]   CliTest.testGenerateCodeFromMultiContract:89
> [ERROR]
>  CliTest.testGenerateServiceCombCodeFromSingleContract:36->lambda$testGenerateServiceCombCodeFromSingleContract$0:54
> [INFO]
> [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
> ```
>
>
> Yours sincerely
>
>
> Yao Haishi
> yhs0092@163.com
>
>
> On 12/6/2019 09:09,Bin Ma<ma...@gmail.com> wrote:
> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Toolkit version 0.2.0
>
>
> Release Candidate :
>
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
>
> Staging Repository :
>
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
>
> Release Tag :
> https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
>
> Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
>
> Release Notes :
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
>
> Keys to verify the Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
>
> Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
> at-least 72 hours, Request all PMC members to give their vote.
>
> [ ] +1 Release this package as 0.2.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because....
>
> On the behalf of ServiceComb Team
>
>
> Wishes & Regards
> -------------------------------
> Mabin
>

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by yhs0092 <yh...@163.com>.
Hello, I find that the `mvn clean install` build is not OK in my development environment. I use a Windows computer to run it.
Here is the error log:
```
[INFO] Running org.apache.servicecomb.toolkit.cli.CliTest
[ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 2.884 s <<< FAILURE! - in org.apache.servicecomb.toolkit.cli.CliTest
[ERROR] testGenerateServiceCombCodeFromSingleContract(org.apache.servicecomb.toolkit.cli.CliTest)  Time elapsed: 0.834 s  <<< FAILURE!
java.lang.AssertionError
        at org.apache.servicecomb.toolkit.cli.CliTest.lambda$testGenerateServiceCombCodeFromSingleContract$0(CliTest.java:54)
        at org.apache.servicecomb.toolkit.cli.CliTest.testGenerateServiceCombCodeFromSingleContract(CliTest.java:36)


[ERROR] testGenerateCodeFromMultiContract(org.apache.servicecomb.toolkit.cli.CliTest)  Time elapsed: 0.602 s  <<< FAILURE!
java.lang.AssertionError
        at org.apache.servicecomb.toolkit.cli.CliTest.testGenerateCodeFromMultiContract(CliTest.java:89)


[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   CliTest.testGenerateCodeFromMultiContract:89
[ERROR]   CliTest.testGenerateServiceCombCodeFromSingleContract:36->lambda$testGenerateServiceCombCodeFromSingleContract$0:54
[INFO]
[ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
```


Yours sincerely


Yao Haishi
yhs0092@163.com


On 12/6/2019 09:09,Bin Ma<ma...@gmail.com> wrote:
Hi All,

This is a call for Vote to release Apache ServiceComb Toolkit version 0.2.0


Release Candidate :
https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/

Staging Repository :
https://repository.apache.org/content/repositories/orgapacheservicecomb-1409

Release Tag :
https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0

Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e

Release Notes :
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158

Keys to verify the Release Candidate :
https://dist.apache.org/repos/dist/dev/servicecomb/KEYS

Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
at-least 72 hours, Request all PMC members to give their vote.

[ ] +1 Release this package as 0.2.0
[ ] +0 No Opinion
[ ] -1 Do not release this package because....

On the behalf of ServiceComb Team


Wishes & Regards
-------------------------------
Mabin

Re: [VOTE] Release Apache ServiceComb Toolkit version 0.2.0

Posted by Daniel Qian <ch...@gmail.com>.
+1

1. Maven build passed: mvn clean install -Pjacoco
2. SHA512 signature checked
3. PGP signature checked

Bin Ma <ma...@gmail.com> 于2019年12月6日周五 上午9:09写道:
>
> Hi All,
>
> This is a call for Vote to release Apache ServiceComb Toolkit version 0.2.0
>
>
> Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/servicecomb-toolkit/0.2.0/rc-01/
>
> Staging Repository :
> https://repository.apache.org/content/repositories/orgapacheservicecomb-1409
>
> Release Tag :
> https://github.com/apache/servicecomb-toolkit/releases/tag/0.2.0
>
> Release CommitID : e95ba3c7b27673ee4e360d64cc1ccce43f70f18e
>
> Release Notes :
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321626&version=12346158
>
> Keys to verify the Release Candidate :
> https://dist.apache.org/repos/dist/dev/servicecomb/KEYS
>
> Voting will start now ( Friday, 6nd Dec, 2019) and will remain open for
> at-least 72 hours, Request all PMC members to give their vote.
>
> [ ] +1 Release this package as 0.2.0
> [ ] +0 No Opinion
> [ ] -1 Do not release this package because....
>
> On the behalf of ServiceComb Team
>
>
> Wishes & Regards
> -------------------------------
> Mabin



-- 
Daniel Qian
Apache Committer(chanjarster)
blog:https://chanjarster.github.io
github:https://github.com/chanjarster
segmentfault: https://segmentfault.com/u/chanjarster