You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "drauschenbach (via GitHub)" <gi...@apache.org> on 2024/11/04 15:00:57 UTC
[PR] Perform CI checks for arm32v7 [arrow-rs]
drauschenbach opened a new pull request, #6678:
URL: https://github.com/apache/arrow-rs/pull/6678
# Which issue does this PR close?
Closes #109.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't attempt to run 64-bit tests on 32-bit platforms [arrow-rs]
Posted by "drauschenbach (via GitHub)" <gi...@apache.org>.
drauschenbach commented on PR #6678:
URL: https://github.com/apache/arrow-rs/pull/6678#issuecomment-2455484328
> I think if we want to support 32-bit platforms we probably want to come up with a holistic plan first. As it stands we don't test against 32-bit architectures and so I likely lots of things won't work correctly.
>
> I suspect there are probably people in the ecosystem interested in this, e.g. for WASM32, but I think we should ensure we're all on the same page and have a coherent plan of action, including for ongoing maintenance.
>
> If this is something you want to drive forwards, perhaps you might file an issue to start the discussion? Unfortunately I have very limited capacity atm.
The comprehensive 32-bit support is already being tracked here: https://github.com/apache/arrow-rs/issues/262. This PR only attempts to close a bug about broken tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't attempt to run 64-bit tests on 32-bit platforms [arrow-rs]
Posted by "drauschenbach (via GitHub)" <gi...@apache.org>.
drauschenbach commented on PR #6678:
URL: https://github.com/apache/arrow-rs/pull/6678#issuecomment-2455895529
> Right, but I'm pretty lukewarm about simply disabling failing tests, many are legitimate bugs. Not only could this mislead people about the current state of support, it would also likely complicate any potential future initiative to actually provide proper support for such architectures.
Thanks for the suggestion @tustvold. I've started the discussion here: https://github.com/apache/arrow-rs/discussions/6680.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't attempt to run 64-bit tests on 32-bit platforms [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed pull request #6678: Don't attempt to run 64-bit tests on 32-bit platforms
URL: https://github.com/apache/arrow-rs/pull/6678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't attempt to run 64-bit tests on 32-bit platforms [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6678:
URL: https://github.com/apache/arrow-rs/pull/6678#issuecomment-2455446724
I think if we want to support 32-bit platforms we probably want to come up with a holistic plan first. As it stands we don't test against 32-bit architectures and so I likely lots of things won't work correctly.
I suspect there are probably people in the ecosystem interested in this, e.g. for WASM32, but I think we should ensure we're all on the same page and have a coherent plan of action, including for ongoing maintenance.
If this is something you want to drive forwards, perhaps you might file an issue to start the discussion? Unfortunately I have very limited capacity atm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't attempt to run 64-bit tests on 32-bit platforms [arrow-rs]
Posted by "drauschenbach (via GitHub)" <gi...@apache.org>.
drauschenbach commented on PR #6678:
URL: https://github.com/apache/arrow-rs/pull/6678#issuecomment-2455437959
## Testing on Raspberry Pi 4B
Running in armhf mode. The easy way to put it into that mode is by installing Raspbian 10.
```sh
$ cargo test
(all tests pass)
```
__Environment__
```sh
$ dpkg --print-architecture
armhf
$ cat /etc/os-release
PRETTY_NAME="Raspbian GNU/Linux 10 (buster)"
NAME="Raspbian GNU/Linux"
VERSION_ID="10"
VERSION="10 (buster)"
VERSION_CODENAME=buster
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Don't attempt to run 64-bit tests on 32-bit platforms [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #6678:
URL: https://github.com/apache/arrow-rs/pull/6678#issuecomment-2455512487
> This PR only attempts to close a bug about broken tests
Right, but I'm pretty lukewarm about simply disabling failing tests. Not only could this mislead people about the current state of support, it would also likely complicate any potential future initiative to actually provide proper support for such architectures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org