You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2023/10/25 07:12:00 UTC
[PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
SteNicholas opened a new pull request, #2042:
URL: https://github.com/apache/incubator-celeborn/pull/2042
### What changes were proposed in this pull request?
Add counter of `outstandingFetches`, `outstandingRpcs` and `outstandingPushes` of `TransportResponseHandler` to metrics of Celeborn Worker.
### Why are the changes needed?
The counter of `outstandingFetches`, `outstandingRpcs` and `outstandingPushes` of `TransportResponseHandler` could be added to metrics to monitor `outstandingFetches`, `outstandingRpcs` and `outstandingPushes`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
`TransportResponseHandlerSuiteJ`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2042:
URL: https://github.com/apache/incubator-celeborn/pull/2042#issuecomment-1778655085
@waitinfuture, @cfmcgrady, sorry for mistake to redundantly incremented gauges (outstandingFetches/outstandingRpcs/outstandingPushes) every time a new TransportResponseHandler instance is created. I have corrected the gauges and added `TransportResponseHandlerSuiteJ#multipleHandleFetchRequest` to verify the gauge instance count. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2042:
URL: https://github.com/apache/incubator-celeborn/pull/2042#issuecomment-1855400370
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2042:
URL: https://github.com/apache/incubator-celeborn/pull/2042#issuecomment-1818451911
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2042: [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics
URL: https://github.com/apache/incubator-celeborn/pull/2042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2042:
URL: https://github.com/apache/incubator-celeborn/pull/2042#issuecomment-1878303132
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2042: [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics
URL: https://github.com/apache/incubator-celeborn/pull/2042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #2042: [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics
URL: https://github.com/apache/incubator-celeborn/pull/2042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2042:
URL: https://github.com/apache/incubator-celeborn/pull/2042#issuecomment-1778686088
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2042?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2042](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2042?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b373a01) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/32a6a31f84f918712db06982a019c6494b1c2341?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (32a6a31) will **increase** coverage by `0.12%`.
> The diff coverage is `90.33%`.
```diff
@@ Coverage Diff @@
## main #2042 +/- ##
==========================================
+ Coverage 46.87% 46.98% +0.12%
==========================================
Files 165 165
Lines 10520 10543 +23
Branches 956 958 +2
==========================================
+ Hits 4930 4953 +23
+ Misses 5272 5271 -1
- Partials 318 319 +1
```
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/celeborn/common/network/TransportContext.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9UcmFuc3BvcnRDb250ZXh0LmphdmE=) | `80.00% <100.00%> (ø)` | |
| [...ommon/network/client/TransportResponseHandler.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0UmVzcG9uc2VIYW5kbGVyLmphdmE=) | `56.92% <94.74%> (+3.27%)` | :arrow_up: |
| [...eleborn/common/metrics/source/AbstractSource.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2042?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3Mvc291cmNlL0Fic3RyYWN0U291cmNlLnNjYWxh) | `37.79% <80.00%> (+2.04%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-255][FOLLOWUP] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics [incubator-celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #2042:
URL: https://github.com/apache/incubator-celeborn/pull/2042#issuecomment-1778666689
@waitinfuture, @cfmcgrady, sorry for mistake to redundantly incremented gauges (outstandingFetches/outstandingRpcs/outstandingPushes) every time a new TransportResponseHandler instance is created in #1992. I have corrected the gauges and added `TransportResponseHandlerSuiteJ#multipleHandleFetchRequest` to verify the gauge instance count. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org