You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/12/04 15:11:44 UTC

[GitHub] [accumulo-classloaders] ctubbsii commented on a change in pull request #5: Fixes #4 - update ReloadingVFSContextClassLoaderFactory for upstream interface changes

ctubbsii commented on a change in pull request #5:
URL: https://github.com/apache/accumulo-classloaders/pull/5#discussion_r536166061



##########
File path: modules/vfs-class-loader/src/main/java/org/apache/accumulo/classloader/vfs/context/ReloadingVFSContextClassLoaderFactory.java
##########
@@ -309,6 +312,11 @@ protected boolean isVMInitialized() {
   @Override
   public synchronized ClassLoader getClassLoader(String contextName)
       throws IllegalArgumentException {
+    try {
+      initializeContexts();
+    } catch (URISyntaxException | IOException e) {
+      throw new RuntimeException("Error initializing contexts", e);
+    }

Review comment:
       Can you just do this in the constructor?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org