You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/27 07:58:45 UTC
[GitHub] [pulsar] zhanghaou opened a new issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
zhanghaou opened a new issue #11814:
URL: https://github.com/apache/pulsar/issues/11814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907052480
> if topic1 and topic2 was putted into same leager , this will be not right.
Does messages from different topics can put into same ledger?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907037224
maybe what we need is to clear the description.
because in get-message-by-id , you know ledgerId and entryId, what topic belongs of the message is very clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907047988
> topic is useless in this command, Maybe we should remove it.
Topic is useful for lookup, and can redirect to the owner broker for finding the managedLedger. But even if we get the wrong managedLedger, we can use the managedLedger to get the message. Maybe we can add createIfMissing in the method 'getLedgerHandle'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907032885
now ,It seems topic only for validate the ledgerId has the topic
when validate success, invoke the ledger to fetch message, there is no check after find the message with id.
if topic1 and topic2 was putted into same leager , this will be not right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-911259497
@zhanghaou
thank you for sharing this finding.
this bug looks like a security issue.
please take into consideration to file a "Security report" for the next time.
This issue is disclosing a potential security risk to a wide audience.
the correct process is to send an email to security@apache.org or to private@pulsar.apache.org
we will follow up with a release soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie closed issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
sijie closed issue #11814:
URL: https://github.com/apache/pulsar/issues/11814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan edited a comment on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
leizhiyuan edited a comment on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907032885
now ,It seems topic only for validate the ledgerId has the topic and some auth etc.
when validate success, invoke the ledger to fetch message, there is no check after find the message with id.
if topic1 and topic2 was putted into same leager , this will be not right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907056784
> Does messages from different topics can put into same ledger?
No。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907018146
> which version do you use？
2.8.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907013925
which version do you use？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zhanghaou commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
zhanghaou commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-912467899
> @zhanghaou
> thank you for sharing this finding.
>
> this bug looks like a security issue.
> please take into consideration to file a "Security report" for the next time.
> This issue is disclosing a potential security risk to a wide audience.
>
> the correct process is to send an email to [security@apache.org](mailto:security@apache.org) or to [private@pulsar.apache.org](mailto:private@pulsar.apache.org)
>
> we will follow up with a release soon
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli removed a comment on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
eolivelli removed a comment on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-911259497
@zhanghaou
thank you for sharing this finding.
this bug looks like a security issue.
please take into consideration to file a "Security report" for the next time.
This issue is disclosing a potential security risk to a wide audience.
the correct process is to send an email to security@apache.org or to private@pulsar.apache.org
we will follow up with a release soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907042798
topic is useless in this command, Maybe we should remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] leizhiyuan commented on issue #11814: [Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name
Posted by GitBox <gi...@apache.org>.
leizhiyuan commented on issue #11814:
URL: https://github.com/apache/pulsar/issues/11814#issuecomment-907044097
> topic is useless in this command, Maybe we should remove it.
but now It has some prechecks, but when checking done,when query message, topic name has no meaning.. I think it is confused sometimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org