You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/16 19:19:00 UTC
[jira] [Work logged] (AVRO-3518) Rust: Represent aliases as Name instead of String
[ https://issues.apache.org/jira/browse/AVRO-3518?focusedWorklogId=770988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770988 ]
ASF GitHub Bot logged work on AVRO-3518:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/22 19:18
Start Date: 16/May/22 19:18
Worklog Time Spent: 10m
Work Description: martin-g opened a new pull request, #1686:
URL: https://github.com/apache/avro/pull/1686
It uses Newtype pattern and wraps Name. This way it is easier to control
how it is being (de)serialized
Until now only Schema::Record serialized its aliases to JSON. Now this
is being done for all named schemata (Schema::Enum and Schema::Fixed)
### Jira
- [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3518
### Tests
- [X] My PR adds new unit tests
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] No need of new documentation
Issue Time Tracking
-------------------
Worklog Id: (was: 770988)
Remaining Estimate: 0h
Time Spent: 10m
> Rust: Represent aliases as Name instead of String
> -------------------------------------------------
>
> Key: AVRO-3518
> URL: https://issues.apache.org/jira/browse/AVRO-3518
> Project: Apache Avro
> Issue Type: Improvement
> Components: rust
> Reporter: Martin Tzvetanov Grigorov
> Assignee: Martin Tzvetanov Grigorov
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently Aliases is an Option<Vec<String>>.
> Since an alias could have a namespace it would be better to use apache_avro::schema::Name for it instead of String.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)