[GitHub] [kafka] satishd commented on a diff in pull request #14459: KAFKA-15511: Catch CorruptIndexException instead of CorruptRecordException

["satishd (via GitHub)" <gi...@apache.org>]

satishd commented on code in PR #14459:
URL: https://github.com/apache/kafka/pull/14459#discussion_r1338550163


##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -598,4 +615,11 @@ class RemoteIndexCacheTest {
       timeIndex.flush()
     }
   }
+
+  private def createCorruptRemoteIndexCacheOffsetFile(): Unit = {
+    val pw =  new PrintWriter((remoteOffsetIndexFile(new File(tpDir,RemoteIndexCache.DIR_NAME),rlsMetadata)))
+    pw.write("Hello, world")

Review Comment:
   @iit2009060 You can run the below command to catch different errors related to check-style, license header checks etc and also runs on different scala versions. It is good to run it before raising PR to catch errors. 
   
   ```
   ./gradlewAll clean releaseTarGz checkStyleMain checkStyleTest spotBugsMain spotBugsTest rat
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org