[GitHub] [skywalking] qixiaobo commented on issue #3084: Wrong display when there is pathvariable in path

[GitBox <gi...@apache.org>]

qixiaobo commented on issue #3084: Wrong display when there is pathvariable in path
URL: https://github.com/apache/skywalking/issues/3084#issuecomment-511751065
 
 
   I noticed that the http tag with SpringMVC may correct.
   Because in springmvc  framework , we may know the requestmapping value.
   But in tomcat ,it can only be requestUrl.
   The code below
   ```java
    HttpServletRequest request = (HttpServletRequest)ContextManager.getRuntimeContext().get(REQUEST_KEY_IN_RUNTIME_CONTEXT);
           if (request != null) {
               StackDepth stackDepth = (StackDepth)ContextManager.getRuntimeContext().get(CONTROLLER_METHOD_STACK_DEPTH);
   
               if (stackDepth == null) {
                   ContextCarrier contextCarrier = new ContextCarrier();
                   CarrierItem next = contextCarrier.items();
                   while (next.hasNext()) {
                       next = next.next();
                       next.setHeadValue(request.getHeader(next.getHeadKey()));
                   }
   
                   AbstractSpan span = ContextManager.createEntrySpan(operationName, contextCarrier);
                   Tags.URL.set(span, request.getRequestURL().toString());
                   Tags.HTTP.METHOD.set(span, request.getMethod());
                   span.setComponent(ComponentsDefine.SPRING_MVC_ANNOTATION);
                   SpanLayer.asHttp(span);
   
                   stackDepth = new StackDepth();
                   ContextManager.getRuntimeContext().put(CONTROLLER_METHOD_STACK_DEPTH, stackDepth);
               } else {
                   AbstractSpan span =
                       ContextManager.createLocalSpan(buildOperationName(objInst, method));
                   span.setComponent(ComponentsDefine.SPRING_MVC_ANNOTATION);
               }
   
               stackDepth.increment();
           }
   ```
   
   but in tomcat 
   ```java
     @Override public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments,
           Class<?>[] argumentsTypes, MethodInterceptResult result) throws Throwable {
           HttpServletRequest request = (HttpServletRequest)allArguments[0];
           ContextCarrier contextCarrier = new ContextCarrier();
   
           CarrierItem next = contextCarrier.items();
           while (next.hasNext()) {
               next = next.next();
               next.setHeadValue(request.getHeader(next.getHeadKey()));
           }
   
           AbstractSpan span = ContextManager.createEntrySpan(request.getRequestURI(), contextCarrier);
           Tags.URL.set(span, request.getRequestURL().toString());
           Tags.HTTP.METHOD.set(span, request.getMethod());
           span.setComponent(ComponentsDefine.TOMCAT);
           SpanLayer.asHttp(span);
   
       }
   ```
   As we can see , sw only set the requestUrl to  url tag.
   So it maybe tomcat plugin has a conflict with springMVC framework???

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services