You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/19 01:24:39 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
nsivabalan opened a new pull request #2456:
URL: https://github.com/apache/hudi/pull/2456
## What is the purpose of the pull request
In a previous commit to bump snapshot version from 0.6.1 to 0.7.0 I did it manually. Even though I verified all artifacts, looks like there was some issue as spark datasource for hudi did not work. Hence reverting old commit and redoing this time w/ mvn command.
Command used:
```
mvn --batch-mode release:update-versions -DdevelopmentVersion=0.7.0-SNAPSHOT
```
## Brief change log
- Fixing 0.7.0 snapshot update
## Verify this pull request
Ran Quick start guide to ensure spark datasource works.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io edited a comment on pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2456:
URL: https://github.com/apache/hudi/pull/2456#issuecomment-762585814
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2456:
URL: https://github.com/apache/hudi/pull/2456#issuecomment-763088405
lets go with this for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2456:
URL: https://github.com/apache/hudi/pull/2456#issuecomment-763088220
@nsivabalan I am just surprised the tool hardcodes all the `parent.version` usages as well. I gave it a shot with `-DautoVersionSubmodules=true` and it still does that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #2456:
URL: https://github.com/apache/hudi/pull/2456#discussion_r559914326
##########
File path: hudi-spark-datasource/hudi-spark-common/pom.xml
##########
@@ -22,7 +22,7 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>hudi-spark-common</artifactId>
- <version>${parent.version}</version>
Review comment:
why are we changing all these parent versions? @nsivabalan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #2456:
URL: https://github.com/apache/hudi/pull/2456#issuecomment-763173195
Sure. sg.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2456:
URL: https://github.com/apache/hudi/pull/2456#issuecomment-763107617
There are some more references to `0.6.1` in a README. I ll let you take care of this in a follow up.
```
./hudi-integ-test/README.md:docker cp packaging/hudi-integ-test-bundle/target/hudi-integ-test-bundle-0.6.1-SNAPSHOT.jar adhoc-2:/opt
./hudi-integ-test/README.md:/opt/hudi-integ-test-bundle-0.6.1-SNAPSHOT.jar \
./hudi-integ-test/README.md:/opt/hudi-integ-test-bundle-0.6.1-SNAPSHOT.jar \
./hudi-integ-test/README.md:/opt/hudi-integ-test-bundle-0.6.1-SNAPSHOT.jar \
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #2456:
URL: https://github.com/apache/hudi/pull/2456#issuecomment-762615009
I followed this https://maven.apache.org/maven-release/maven-release-plugin/examples/update-versions.html
Previously, I just manually edited every pom file to change 0.6.1 to 0.7.0. With this PR, I reverted that specific commit. And ran the command given in the description(got it from [here](https://maven.apache.org/maven-release/maven-release-plugin/examples/update-versions.html) ) and created this PR. I did not do any other changes by myself this time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io commented on pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2456:
URL: https://github.com/apache/hudi/pull/2456#issuecomment-762585814
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2456?src=pr&el=h1) Report
> Merging [#2456](https://codecov.io/gh/apache/hudi/pull/2456?src=pr&el=desc) (e64c19b) into [master](https://codecov.io/gh/apache/hudi/commit/684e12e9fcfa45c6ac922a84fb3116ac8142bc18?el=desc) (684e12e) will **decrease** coverage by `41.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2456?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2456 +/- ##
============================================
- Coverage 50.71% 9.68% -41.03%
+ Complexity 3060 48 -3012
============================================
Files 419 53 -366
Lines 18801 1930 -16871
Branches 1922 230 -1692
============================================
- Hits 9534 187 -9347
+ Misses 8492 1730 -6762
+ Partials 775 13 -762
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudicli | `?` | `?` | |
| hudiclient | `100.00% <ø> (ø)` | `0.00 <ø> (ø)` | |
| hudicommon | `?` | `?` | |
| hudiflink | `?` | `?` | |
| hudihadoopmr | `?` | `?` | |
| hudisparkdatasource | `?` | `?` | |
| hudisync | `?` | `?` | |
| huditimelineservice | `?` | `?` | |
| hudiutilities | `9.68% <ø> (-59.80%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/hudi/pull/2456?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/hudi/utilities/IdentitySplitter.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL0lkZW50aXR5U3BsaXR0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...va/org/apache/hudi/utilities/schema/SchemaSet.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFTZXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...a/org/apache/hudi/utilities/sources/RowSource.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUm93U291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [.../org/apache/hudi/utilities/sources/AvroSource.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQXZyb1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../org/apache/hudi/utilities/sources/JsonSource.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvblNvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rg/apache/hudi/utilities/sources/CsvDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvQ3N2REZTU291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
| [...g/apache/hudi/utilities/sources/JsonDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvbkRGU1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...apache/hudi/utilities/sources/JsonKafkaSource.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvSnNvbkthZmthU291cmNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...pache/hudi/utilities/sources/ParquetDFSSource.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NvdXJjZXMvUGFycXVldERGU1NvdXJjZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...lities/schema/SchemaProviderWithPostProcessor.java](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL3NjaGVtYS9TY2hlbWFQcm92aWRlcldpdGhQb3N0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [396 more](https://codecov.io/gh/apache/hudi/pull/2456/diff?src=pr&el=tree-more) | |
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar merged pull request #2456: [HUDI-1535] Fix0.7.0 snapshot
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #2456:
URL: https://github.com/apache/hudi/pull/2456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org