You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/18 06:27:24 UTC
[GitHub] [apisix] bisakhmondal opened a new pull request #5543: doc: addition of multi language support into readme
bisakhmondal opened a new pull request #5543:
URL: https://github.com/apache/apisix/pull/5543
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
closes #5502
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5543: docs: addition of multi language support into readme
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5543:
URL: https://github.com/apache/apisix/pull/5543#discussion_r752027247
##########
File path: README.md
##########
@@ -146,6 +146,12 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- Custom load balancing algorithms: You can use custom load balancing algorithms during the `balancer` phase.
- Custom routing: Support users to implement routing algorithms themselves.
+- **Multi-Language support**
+ - Apache APISIX is a multi-language gateway for plugin development and provides support via `WASM` and `RPC`.
+ 
+ - The WASM or WebAssembly, is the modern way. If we look at the left part, APISIX can load and run WASM bytecode via APISIX wasm plugin, so developers only need to write the code according to the SDK and then compile it into a WASM bytecode file and put it in the APISIX folder. As of now, APISIX has support for Golang SDK and Rust SDK - more language SDKs will be supported in the future.
Review comment:
Hi @membphis, one question - if the wasm plugin of apache apisix just runs the wasm bytecode why are we limited only to the Go and Rust? At the end of the day, it's the bytecode instructions that we need to run on wasm, right?
https://webassembly.org/getting-started/developers-guide/
This official URL shows the list of languages where the programs can e compiled for wasm virtual machine. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on pull request #5543: docs: addition of multi language support into readme
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on pull request #5543:
URL: https://github.com/apache/apisix/pull/5543#issuecomment-972576479
cc @membphis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #5543: docs: addition of multi language support into readme
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #5543:
URL: https://github.com/apache/apisix/pull/5543#discussion_r751949556
##########
File path: README.md
##########
@@ -146,6 +146,12 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- Custom load balancing algorithms: You can use custom load balancing algorithms during the `balancer` phase.
- Custom routing: Support users to implement routing algorithms themselves.
+- **Multi-Language support**
+ - Apache APISIX is a multi-language gateway for plugin development and provides support via `WASM` and `RPC`.
+ 
+ - The WASM or WebAssembly, is the modern way. If we look at the left part, APISIX can load and run WASM bytecode via APISIX wasm plugin, so developers only need to write the code according to the SDK and then compile it into a WASM bytecode file and put it in the APISIX folder. As of now, APISIX has support for Golang SDK and Rust SDK - more language SDKs will be supported in the future.
Review comment:
we can add a link for `Golang SDK` and `Rust SDK` later.
##########
File path: README.md
##########
@@ -146,6 +146,12 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- Custom load balancing algorithms: You can use custom load balancing algorithms during the `balancer` phase.
- Custom routing: Support users to implement routing algorithms themselves.
+- **Multi-Language support**
+ - Apache APISIX is a multi-language gateway for plugin development and provides support via `WASM` and `RPC`.
+ 
+ - The WASM or WebAssembly, is the modern way. If we look at the left part, APISIX can load and run WASM bytecode via APISIX wasm plugin, so developers only need to write the code according to the SDK and then compile it into a WASM bytecode file and put it in the APISIX folder. As of now, APISIX has support for Golang SDK and Rust SDK - more language SDKs will be supported in the future.
+ - The RPC way, is a traditional way. If we look at the right part, developers can choose the language according to their needs. After starting an independent process with the RPC, it exchanges data with APISIX through local RPC communication. Till this moment, APISIX has support for Java， Golang, Python and Node.js.
Review comment:
same issue, we can add a link to `Golang`, `Python` and `Java`.
eg: the Java should be linked to https://github.com/apache/apisix-java-plugin-runner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5543: docs: addition of multi language support into readme
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5543:
URL: https://github.com/apache/apisix/pull/5543#discussion_r752093937
##########
File path: README.md
##########
@@ -146,6 +146,12 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- Custom load balancing algorithms: You can use custom load balancing algorithms during the `balancer` phase.
- Custom routing: Support users to implement routing algorithms themselves.
+- **Multi-Language support**
+ - Apache APISIX is a multi-language gateway for plugin development and provides support via `WASM` and `RPC`.
+ 
+ - The WASM or WebAssembly, is the modern way. If we look at the left part, APISIX can load and run WASM bytecode via APISIX wasm plugin, so developers only need to write the code according to the SDK and then compile it into a WASM bytecode file and put it in the APISIX folder. As of now, APISIX has support for [Golang SDK](https://github.com/golang/go/wiki/WebAssembly#getting-started) and [Rust SDK](https://developer.mozilla.org/en-US/docs/WebAssembly/Rust_to_wasm) - more language SDKs will be supported in the future.
Review comment:
The SDK should be https://github.com/proxy-wasm/spec#sdks.
And there are not just Go/Rust.
And there is no requirement to `put it in the APISIX folder`.
See https://github.com/apache/apisix/blob/master/docs/en/latest/wasm.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5543: docs: addition of multi language support into readme
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #5543:
URL: https://github.com/apache/apisix/pull/5543#issuecomment-975015802
@bisakhmondal Hi, please resolve those conflicts, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #5543: docs: addition of multi language support into readme
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #5543:
URL: https://github.com/apache/apisix/pull/5543#discussion_r752789720
##########
File path: README.md
##########
@@ -146,6 +146,12 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- Custom load balancing algorithms: You can use custom load balancing algorithms during the `balancer` phase.
- Custom routing: Support users to implement routing algorithms themselves.
+- **Multi-Language support**
+ - Apache APISIX is a multi-language gateway for plugin development and provides support via `WASM` and `RPC`.
+ 
+ - The WASM or WebAssembly, is the modern way. If we look at the left part, APISIX can load and run WASM bytecode via APISIX wasm plugin, so developers only need to write the code according to the SDK and then compile it into a WASM bytecode file and put it in the APISIX folder. As of now, APISIX has support for [Golang SDK](https://github.com/golang/go/wiki/WebAssembly#getting-started) and [Rust SDK](https://developer.mozilla.org/en-US/docs/WebAssembly/Rust_to_wasm) - more language SDKs will be supported in the future.
Review comment:
ping @bisakhmondal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5543: docs: addition of multi language support into readme
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5543:
URL: https://github.com/apache/apisix/pull/5543#discussion_r753940197
##########
File path: README.md
##########
@@ -146,6 +146,12 @@ A/B testing, canary release, blue-green deployment, limit rate, defense against
- Custom load balancing algorithms: You can use custom load balancing algorithms during the `balancer` phase.
- Custom routing: Support users to implement routing algorithms themselves.
+- **Multi-Language support**
+ - Apache APISIX is a multi-language gateway for plugin development and provides support via `WASM` and `RPC`.
+ 
+ - The WASM or WebAssembly, is the modern way. If we look at the left part, APISIX can load and run WASM bytecode via APISIX wasm plugin, so developers only need to write the code according to the SDK and then compile it into a WASM bytecode file and put it in the APISIX folder. As of now, APISIX has support for [Golang SDK](https://github.com/golang/go/wiki/WebAssembly#getting-started) and [Rust SDK](https://developer.mozilla.org/en-US/docs/WebAssembly/Rust_to_wasm) - more language SDKs will be supported in the future.
Review comment:
Ah, I got it now. The sdk means - the proxy wasm SDK. Updated accordingly. Is it okay now?
cc @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #5543: docs: addition of multi language support into readme
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #5543:
URL: https://github.com/apache/apisix/pull/5543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org