You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/12/22 17:39:29 UTC

Review Request 41647: Handle schemaless value for ams-hbase-site/hbase.rootdir

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41647/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan and Sid Wagle.


Bugs: AMBARI-14467
    https://issues.apache.org/jira/browse/AMBARI-14467


Repository: ambari


Description
-------

if default fs is set
"core-site": {
"fs.defaultFS": "wasb://#DefaultContainerName@#DefaultStorageAccountName.host.domain",
hbase.rootdir values started from "/" might be set
"hbase-site": {
"hbase.rootdir": "/hbase",
stack advisor should also take into account core-site/fs.defaultFS value


Diffs
-----

  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml e97cfee 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py a723f75 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py d79b2ad 

Diff: https://reviews.apache.org/r/41647/diff/


Testing
-------

Tested manually + unit tests passed
----------------------------------------------------------------------
Ran 250 tests in 8.203s

OK
----------------------------------------------------------------------
Total run:856
Total errors:0
Total failures:0
OK


Thanks,

Dmytro Sen


Re: Review Request 41647: Handle schemaless value for ams-hbase-site/hbase.rootdir

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41647/#review111692
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On Dec. 22, 2015, 4:39 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41647/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 4:39 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-14467
>     https://issues.apache.org/jira/browse/AMBARI-14467
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> if default fs is set
> "core-site": {
> "fs.defaultFS": "wasb://#DefaultContainerName@#DefaultStorageAccountName.host.domain",
> hbase.rootdir values started from "/" might be set
> "hbase-site": {
> "hbase.rootdir": "/hbase",
> stack advisor should also take into account core-site/fs.defaultFS value
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml e97cfee 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py a723f75 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py d79b2ad 
> 
> Diff: https://reviews.apache.org/r/41647/diff/
> 
> 
> Testing
> -------
> 
> Tested manually + unit tests passed
> ----------------------------------------------------------------------
> Ran 250 tests in 8.203s
> 
> OK
> ----------------------------------------------------------------------
> Total run:856
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>