You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "FrankYang0529 (via GitHub)" <gi...@apache.org> on 2025/01/09 12:05:56 UTC
[PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (8/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
FrankYang0529 opened a new pull request, #18461:
URL: https://github.com/apache/kafka/pull/18461
JIRA: https://issues.apache.org/jira/browse/KAFKA-18399
Remove ZK support for OFFSET_COMMIT and OFFSET_FETCH.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (4/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #18461:
URL: https://github.com/apache/kafka/pull/18461#issuecomment-2586665247
@chia7712 It is totally fine to merge it. I was referring to the reviewers in the commit message: `Reviewers: Chia-Ping Tsai <ch...@gmail.com>`. I suppose that you just forgot me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (4/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18461:
URL: https://github.com/apache/kafka/pull/18461#issuecomment-2586680018
> I suppose that you just forgot me.
that is my fault. I should not merge PR after working over 24 hours :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (4/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18461:
URL: https://github.com/apache/kafka/pull/18461#issuecomment-2586248506
> Any reason why you did not?
I have verified that all your comments have been addressed. Merging this PR can facilitate the progress of other ZK-related code cleanups. We can address any remaining feedback in subsequent PRs, such as those related to other cleanups. However, this is my perspective. I will await your second review next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (8/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #18461:
URL: https://github.com/apache/kafka/pull/18461#discussion_r1909083137
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1230,58 +1191,13 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleOffsetFetchRequest(request: RequestChannel.Request): CompletableFuture[Unit] = {
val version = request.header.apiVersion
if (version == 0) {
- handleOffsetFetchRequestFromZookeeper(request)
+ requestHelper.sendMaybeThrottle(request, request.body[OffsetFetchRequest].getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
+ CompletableFuture.completedFuture(())
Review Comment:
Updated it. Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (8/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #18461:
URL: https://github.com/apache/kafka/pull/18461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (4/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #18461:
URL: https://github.com/apache/kafka/pull/18461#issuecomment-2586143058
@chia7712 You could have mentioned me as a reviewer on this one. Any reason why you did not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (8/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on PR #18461:
URL: https://github.com/apache/kafka/pull/18461#issuecomment-2581938895
The failed case `RemoteLogManagerTest#testStopPartitionsWithDeletion` will be fixed in https://github.com/apache/kafka/pull/18474.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18399: Remove ZooKeeper from KafkaApis (8/N): OFFSET_COMMIT and OFFSET_FETCH [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #18461:
URL: https://github.com/apache/kafka/pull/18461#discussion_r1908955860
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -508,12 +508,8 @@ class KafkaApis(val requestChannel: RequestChannel,
CompletableFuture.completedFuture(())
} else if (request.header.apiVersion == 0) {
// For version 0, always store offsets in ZK.
- commitOffsetsToZookeeper(
- request,
- offsetCommitRequest,
- authorizedTopicsRequest,
- responseBuilder
- )
+ requestHelper.sendMaybeThrottle(request, offsetCommitRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
Review Comment:
I think that we removed version 0 of that API so we could remove the entire branch.
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1230,58 +1191,13 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleOffsetFetchRequest(request: RequestChannel.Request): CompletableFuture[Unit] = {
val version = request.header.apiVersion
if (version == 0) {
- handleOffsetFetchRequestFromZookeeper(request)
+ requestHelper.sendMaybeThrottle(request, request.body[OffsetFetchRequest].getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
+ CompletableFuture.completedFuture(())
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org