[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2061: Refactor arm interrupt stack related code

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#discussion_r509993414



##########
File path: arch/arm/src/armv7-a/arm_vectors.S
##########
@@ -1096,7 +1098,7 @@ g_intstackbase:
 	.type	g_fiqstackbase, object
 
 g_fiqstackalloc:
-	.skip	((CONFIG_ARCH_INTERRUPTSTACK & ~7) - 4)
+	.skip	(CONFIG_ARCH_INTERRUPTSTACK & ~7)

Review comment:
       Should we keep the `.skip` in the base below?

##########
File path: arch/arm/src/armv7-m/gnu/arm_exception.S
##########
@@ -321,9 +322,9 @@ exception_common:
 	.bss
 	.global	g_intstackalloc
 	.global	g_intstackbase
-	.align	8
+	.balign	8
 g_intstackalloc:
-	.skip	((CONFIG_ARCH_INTERRUPTSTACK + 4) & ~7)
+	.skip	(CONFIG_ARCH_INTERRUPTSTACK & ~7)

Review comment:
       Shouldn't we align up here? `((CONFIG_ARCH_INTERRUPTSTACK + 7) & ~7)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org