You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Varun Thacker (JIRA)" <ji...@apache.org> on 2018/06/21 11:56:00 UTC

[jira] [Commented] (SOLR-11391) JoinQParser for non point fields should use the GraphTermsCollector

    [ https://issues.apache.org/jira/browse/SOLR-11391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519267#comment-16519267 ] 

Varun Thacker commented on SOLR-11391:
--------------------------------------

Finally getting back to this. It's been a while but here's what I am thinking 

"JoinQParser for non point fields should use the GraphTermsCollector" - Stick to this Jira description. So shorten the scope here and just work on the JoinQParser part 

Then in a followup Jira work on making JSON Facets take advantage of this. 

I'll address Hoss's feedback in my next patch 

 

> JoinQParser for non point fields should use the GraphTermsCollector 
> --------------------------------------------------------------------
>
>                 Key: SOLR-11391
>                 URL: https://issues.apache.org/jira/browse/SOLR-11391
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Varun Thacker
>            Priority: Major
>         Attachments: SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch, SOLR-11391.patch
>
>
> The Join Query Parser uses the GraphPointsCollector for point fields. 
> For non point fields if we use the GraphTermsCollector instead of the current algorithm I am seeing quite a bit of performance gains.
> I'm going to attach a quick patch which I cooked up , making sure TestJoin and TestCloudJSONFacetJoinDomain passed. 
> More tests, benchmarking and code cleanup to follow



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org