You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/07/07 20:09:06 UTC

[GitHub] zeppelin pull request #1149: [HOTFIX] Master branch build fail after merge c...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/1149

    [HOTFIX] Master branch build fail after merge ca4e587f11a90169b7ae95fe53ce909b5226cf1a

    ### What is this PR for?
    Fixes master branch build fail with error
    
    ```
    [INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build) @ zeppelin-web ---
    [INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web
    [INFO] Running "jshint:all" (jshint) task
    [INFO] 
    [INFO] \u2714 No problems
    [INFO] 
    [INFO] 
    [INFO] Running "htmlhint:src" (htmlhint) task
    [INFO]    src/index.html
    [INFO]       L57 |    <link rel="stylesheet" href="app/jobmanager/jobmanager.css">
    [INFO]                ^ The empty tag : [ link ] must be self closed. (tag-self-close)
    [INFO]       L58 |    <link rel="stylesheet" href="app/jobmanager/jobs/job.css">
    [INFO]                ^ The empty tag : [ link ] must be self closed. (tag-self-close)
    [INFO] 
    [INFO] >> 2 errors in 1 files
    [INFO] Warning: Task "htmlhint:src" failed. Use --force to continue.
    [INFO] 
    [INFO] Aborted due to warnings.
    ```
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - close tag
    
    ### What is the Jira issue?
    ZEPPELIN-964, ZEPPELIN-1088
    
    ### Questions:
    * Does the licenses files need update? no 
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin hotfix_964

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1149.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1149
    
----
commit 96f8231a277288c5f6ea3279021b043444250174
Author: Lee moon soo <mo...@apache.org>
Date:   2016-07-07T20:08:19Z

    close tag

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1149: [HOTFIX] Master branch build fail after merge ca4e587f...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1149
  
    I'm merging it into master as a hotfix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1149: [HOTFIX] Master branch build fail after merge c...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1149


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---