You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tw...@apache.org on 2021/11/08 11:16:52 UTC

[flink] branch master updated: [FLINK-24414][table-planner] Remove example test for left padding of decimals

This is an automated email from the ASF dual-hosted git repository.

twalthr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new bb32c79  [FLINK-24414][table-planner] Remove example test for left padding of decimals
bb32c79 is described below

commit bb32c79706fed2f79aadb9aa38c11df8010eacb1
Author: Marios Trivyzas <ma...@gmail.com>
AuthorDate: Fri Nov 5 12:37:55 2021 +0100

    [FLINK-24414][table-planner] Remove example test for left padding of decimals
    
    After discussion on the issue, was decided to not support left padding of decimals,
    to the integral digits specified by precision-scale, as major DBs also don't support
    it. Removing the example issue in the IT cast tests.
    
    This closes #17694.
---
 .../org/apache/flink/table/planner/functions/CastFunctionITCase.java   | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java b/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
index e37ff38..63dfd78 100644
--- a/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
+++ b/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java
@@ -160,9 +160,6 @@ public class CastFunctionITCase extends BuiltInFunctionTestBase {
                         .fromCase(BYTES(), DEFAULT_BYTES, "\u0000\u0001\u0002\u0003\u0004")
                         .fromCase(DECIMAL(4, 3), 9.87, "9.870")
                         .fromCase(DECIMAL(10, 5), 1, "1.00000")
-                        // https://issues.apache.org/jira/browse/FLINK-24414 - Left zero padding
-                        // currently not working
-                        // .fromCase(DECIMAL(5, 3), 09.87, "09.870")
                         .fromCase(
                                 TINYINT(),
                                 DEFAULT_POSITIVE_TINY_INT,