You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/03/22 23:46:25 UTC
[GitHub] [fineract] vidakovic opened a new pull request #2171: FINERACT-1532: Create an example for pluggability
vidakovic opened a new pull request #2171:
URL: https://github.com/apache/fineract/pull/2171
Proof of concept to demonstrate modularity with a minimum of additional configuration. Documentation started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #2171: FINERACT-1532: Create an example for pluggability
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #2171:
URL: https://github.com/apache/fineract/pull/2171#discussion_r834121298
##########
File path: fineract-provider/src/main/resources/META-INF/spring.factories
##########
@@ -0,0 +1,2 @@
+org.springframework.boot.autoconfigure.EnableAutoConfiguration=\
Review comment:
... yeah... was thinking the same when I put it in place... I guess technically we don't need it in this setup... probably my thinking was to put stuff in place and later move to separate modules; I guess there's an argument to keep only the bare minimum.
What I'll do: add a section in the documentation describing the anatomy of a clean module; anyone who wants to port an existing or creating a new one has then a detailed todo list. Alright, working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a change in pull request #2171: FINERACT-1532: Create an example for pluggability
Posted by GitBox <gi...@apache.org>.
galovics commented on a change in pull request #2171:
URL: https://github.com/apache/fineract/pull/2171#discussion_r834088714
##########
File path: fineract-provider/src/main/resources/META-INF/spring.factories
##########
@@ -0,0 +1,2 @@
+org.springframework.boot.autoconfigure.EnableAutoConfiguration=\
Review comment:
Since this is part of the intermediate solution - while the modules are properly extracted - does it make sense to have it configured like this? The component scan would pick this up after all in fineract-provider. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a change in pull request #2171: FINERACT-1532: Create an example for pluggability
Posted by GitBox <gi...@apache.org>.
galovics commented on a change in pull request #2171:
URL: https://github.com/apache/fineract/pull/2171#discussion_r834088714
##########
File path: fineract-provider/src/main/resources/META-INF/spring.factories
##########
@@ -0,0 +1,2 @@
+org.springframework.boot.autoconfigure.EnableAutoConfiguration=\
Review comment:
Since this is part of the intermediate solution - while the modules are properly extracted - does it make sense to have this configured like this? The component scan would pick this up after all in fineract-provider. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2171: FINERACT-1532: Create an example for pluggability
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #2171:
URL: https://github.com/apache/fineract/pull/2171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org