You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/20 13:39:14 UTC

[GitHub] [airflow] mik-laj opened a new pull request #11033: Add a new example to use cluster policy

mik-laj opened a new pull request #11033:
URL: https://github.com/apache/airflow/pull/11033


   Users tell us they need to restrict the launch of new tasks based on the connection. This is not officially supported by Airflow, so I am adding an example workaround for this and I hope some users will find it helpful.
   
   Part of: https://github.com/apache/airflow/issues/9755
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #11033: Add example to use cluster policy - Maintenance mode for conn

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11033:
URL: https://github.com/apache/airflow/pull/11033#discussion_r491693880



##########
File path: tests/cluster_policies/task_mutation_connection.py
##########
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.models.pool import Pool
+
+
+# [START task_mutation_connection]
+def policy(task):
+    if task.pool == Pool.DEFAULT_POOL_NAME:
+        conn_id = getattr(task, 'conn_id') or getattr(task, 'gcp_conn_id')

Review comment:
       Do we have other cases where connection id is specified differently than that in task? Can there be for example tasks that use hooks with default connection ids and connection ids are not specified in the task_id. How are we going to handle those cases? Or maybe we should explicitly state here what are the border conditions for this rule to work? 
   
   How about transfer operators when we have several different connection ids per task?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] stale[bot] commented on pull request #11033: Add example to use cluster policy - Maintenance mode for conn

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #11033:
URL: https://github.com/apache/airflow/pull/11033#issuecomment-751239988


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #11033: Add example to use cluster policy - Maintenance mode for conn

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11033:
URL: https://github.com/apache/airflow/pull/11033#issuecomment-792130061


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #11033: Add example to use cluster policy - Maintenance mode for conn

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11033:
URL: https://github.com/apache/airflow/pull/11033#issuecomment-751293696


   Are you going to continue this one @mik-laj ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] closed pull request #11033: Add example to use cluster policy - Maintenance mode for conn

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #11033:
URL: https://github.com/apache/airflow/pull/11033


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #11033: Add example to use cluster policy - Maintenance mode for conn

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11033:
URL: https://github.com/apache/airflow/pull/11033#discussion_r491693880



##########
File path: tests/cluster_policies/task_mutation_connection.py
##########
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from airflow.models.pool import Pool
+
+
+# [START task_mutation_connection]
+def policy(task):
+    if task.pool == Pool.DEFAULT_POOL_NAME:
+        conn_id = getattr(task, 'conn_id') or getattr(task, 'gcp_conn_id')

Review comment:
       Do we have other cases where connection id is specified differently than that in task? Can there be for example tasks that use hooks with default connection ids and connection ids are not specified in the task_id. How are we going to handle those cases? Or maybe we should explicitly state here what are the border conditions for this rule to work? 
   
   How about transfer operators when we have several different connection ids per task?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org